Re: mac80211 truesize bugs

David Miller
2008-05-13T22:09:31Z

From: Johannes Berg <johannes@sipsolutions.net>
Date: Tue, 13 May 2008 23:37:23 +0200

>
> > > Most fullmac devices also need some space, whether they do things that
> > > way or not is a completely different thing, the ieee80211 stack for
> > > example copies every packet into a new skb anyway.
> >
> > It's really depends on when is the 802.3 to 802.11 header translation
> > made it doesn't matter whether it's fullmac or softmac. I would say
> > that WLAN is OK.
>
> True, some devices take 802.3 frames and do the translation and
> everything themselves. I dunno. I guess it would make sense to make it
> mac80211 anyway because ieee80211 doesn't care and the other drivers are
> probably handling this in some other way anyway (if maybe even by using
> different dma descriptors, or just not caring because transfer speeds
> are low enough)

We should fix ieee80211 (it's something I planned to look into today
in fact), and the drivers that copy or do things incorrectly.

It doesn't make sense to make this decision based upon which 80211
stack or which drivers are enabled. All of them in essence want this
extra space, so let's give it to them.