Re: [PATCH/RFC] mac80211: fix association with some APs

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 1249 bytes --]

On Thu, 2008-05-08 at 10:30 +0200, Helmut Schaa wrote:
> Some APs refuse association if the supported rates contained in the association
> request do not match its own supported rates. This patch introduces a new
> function which builds the intersection between the AP's supported rates and the
> client's supported rates to work around such problems. The same approach is
> already used in ipw2200 for example.

Clearly, somebody didn't read the spec. *sigh*

Quote:

10.3.3.1.2, parameter table (emphasis mine):

OperationalRateSet

The set of data rates that the STA desires
to use for communication within the BSS.
The STA must be able to receive at each
of the data rates listed in the set. This set
                                     ^^^^^^^^
is a superset of the rates contained in the
^^^^^^^^^^^^^^^^^^^^^^^^^^
BSSBasicRateSet parameter.



>  
> +	rates_len = ieee80211_compatible_rates(bss, sband, &rates);
> +	supp_rates_len = rates_len;
> +	if (supp_rates_len > 8)
> +		supp_rates_len = 8;

Please add a comment here why we do this, preferably including at least
one broken AP (so we can blame somebody ;) )

> +	if (count == 8)
> +	{

and fix this tiny coding style problem please.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]