From: Johannes Berg <johannes@sipsolutions.net>
To: Ivo van Doorn <ivdoorn@gmail.com>
Cc: linux-wireless@vger.kernel.org, rt2400-devel@lists.sourceforge.net
Subject: Re: [PATCH 2/5] mac80211: Initialize sta pointer
Date: Sat, 10 May 2008 18:22:39 +0200 [thread overview]
Message-ID: <1210436559.12837.7.camel@johannes.berg> (raw)
In-Reply-To: <200805101350.43435.IvDoorn@gmail.com> (sfid-20080510_141037_403869_ADA86AE6)
[-- Attachment #1: Type: text/plain, Size: 604 bytes --]
On Sat, 2008-05-10 at 13:50 +0200, Ivo van Doorn wrote:
> patch: mac80211: rewrite fragmentation code
> introduced the following compile warning:
>
> net/mac80211/tx.c: In function 'ieee80211_master_start_xmit':
> net/mac80211/tx.c:1244: warning: 'sta' may be used uninitialized in this function
>
> sta is allowed to be NULL throughout the rest of the function,
> so we best initialize it to NULL.
Thanks. Not sure what's wrong with my compiler :) I'm still working on
this patch and it probably won't go into the tree in it's current form
since Herbert Xu had reservations.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2008-05-10 16:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-10 11:49 [PATCH 0/5] mac80211 & rt2x00 updates Ivo van Doorn
2008-05-10 11:49 ` [PATCH 1/5] rt2x00: use rate index in TX control Ivo van Doorn
2008-05-10 11:50 ` [PATCH 3/5] rt2x00: use multi-queue master netdevice Ivo van Doorn
2008-05-10 11:50 ` [PATCH 2/5] mac80211: Initialize sta pointer Ivo van Doorn
2008-05-10 16:22 ` Johannes Berg [this message]
2008-05-10 11:51 ` [PATCH 4/5] rt2x00: Convert rt2x00 to read control info from skb->cb Ivo van Doorn
2008-05-10 21:20 ` Johannes Berg
2008-05-11 9:13 ` Ivo van Doorn
2008-05-11 11:33 ` Ivo van Doorn
2008-05-11 11:49 ` Johannes Berg
2008-05-11 12:13 ` Ivo van Doorn
2008-05-10 11:51 ` [PATCH 5/5] mac80211: Match define names in comments with actual defines Ivo van Doorn
2008-05-10 16:21 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1210436559.12837.7.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=ivdoorn@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rt2400-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).