[RFC PATCH] mac80211 : Association with 11n hidden ssid ap.

[RFC PATCH] mac80211 : Association with 11n hidden ssid ap.

[Abhijeet Kolekar]

This patch fixes the association problem with 11n hidden ssid ap.
Patch fixes the problem of associating with hidden ssid when
all three parameters ap,essid and channel are given to iwconfig.
This patch removes the condition of checking three parameters
and always checks for bss in bss list while associating.

Signed-off-by: Abhijeet Kolekar <abhijeet.kolekar@intel.com>
---
 net/mac80211/mlme.c |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
index cb01995..872b105 100644
--- a/net/mac80211/mlme.c
+++ b/net/mac80211/mlme.c
@@ -3390,13 +3390,6 @@ static int ieee80211_sta_config_auth(struct net_device *dev,
 	struct ieee80211_sta_bss *bss, *selected = NULL;
 	int top_rssi = 0, freq;
 
-	if (!(ifsta->flags & (IEEE80211_STA_AUTO_SSID_SEL |
-	    IEEE80211_STA_AUTO_BSSID_SEL | IEEE80211_STA_AUTO_CHANNEL_SEL))) {
-		ifsta->state = IEEE80211_AUTHENTICATE;
-		ieee80211_sta_reset_auth(dev, ifsta);
-		return 0;
-	}
-
 	spin_lock_bh(&local->sta_bss_lock);
 	freq = local->oper_channel->center_freq;
 	list_for_each_entry(bss, &local->sta_bss_list, list) {
-- 
1.5.2.5

Re: [RFC PATCH] mac80211 : Association with 11n hidden ssid ap.

[Zhu Yi]

On Fri, 2008-05-09 at 09:35 -0700, Abhijeet Kolekar wrote:
> This patch fixes the association problem with 11n hidden ssid ap.
> Patch fixes the problem of associating with hidden ssid when
> all three parameters ap,essid and channel are given to iwconfig.
> This patch removes the condition of checking three parameters
> and always checks for bss in bss list while associating.

Johannes, can you please take a look at this patch? The original code
looks like a shortcut to start authentication/association when all the
three parameters (BSSID/SSID/CHANNEL) are provided. But this is not
sufficient in the case of associate with an 11N hidden SSID AP. The 11n
and wmm information must be retrieved by an active probe request. Not
doing so will cause the 11N AP refuse to associate with the client.

Thanks,
-yi

> Signed-off-by: Abhijeet Kolekar <abhijeet.kolekar@intel.com>
> ---
>  net/mac80211/mlme.c |    7 -------
>  1 files changed, 0 insertions(+), 7 deletions(-)
> 
> diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
> index cb01995..872b105 100644
> --- a/net/mac80211/mlme.c
> +++ b/net/mac80211/mlme.c
> @@ -3390,13 +3390,6 @@ static int ieee80211_sta_config_auth(struct net_device *dev,
>  	struct ieee80211_sta_bss *bss, *selected = NULL;
>  	int top_rssi = 0, freq;
>  
> -	if (!(ifsta->flags & (IEEE80211_STA_AUTO_SSID_SEL |
> -	    IEEE80211_STA_AUTO_BSSID_SEL | IEEE80211_STA_AUTO_CHANNEL_SEL))) {
> -		ifsta->state = IEEE80211_AUTHENTICATE;
> -		ieee80211_sta_reset_auth(dev, ifsta);
> -		return 0;
> -	}
> -
>  	spin_lock_bh(&local->sta_bss_lock);
>  	freq = local->oper_channel->center_freq;
>  	list_for_each_entry(bss, &local->sta_bss_list, list) {

Re: [RFC PATCH] mac80211 : Association with 11n hidden ssid ap.

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 953 bytes --]


> Johannes, can you please take a look at this patch? The original code
> looks like a shortcut to start authentication/association when all the
> three parameters (BSSID/SSID/CHANNEL) are provided. But this is not
> sufficient in the case of associate with an 11N hidden SSID AP. The 11n
> and wmm information must be retrieved by an active probe request. Not
> doing so will cause the 11N AP refuse to associate with the client.


> > -	if (!(ifsta->flags & (IEEE80211_STA_AUTO_SSID_SEL |
> > -	    IEEE80211_STA_AUTO_BSSID_SEL | IEEE80211_STA_AUTO_CHANNEL_SEL))) {
> > -		ifsta->state = IEEE80211_AUTHENTICATE;
> > -		ieee80211_sta_reset_auth(dev, ifsta);
> > -		return 0;
> > -	}
> > -
> >  	spin_lock_bh(&local->sta_bss_lock);

Well, I'm not sure I'm the right person to look at this, I'm very
unfamiliar with the code in question. For all I care we can put it in
and revert/fixup when we get bug reports from it.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

Re: [RFC PATCH] mac80211 : Association with 11n hidden ssid ap.

[Zhu Yi]

On Tue, 2008-05-13 at 10:35 +0200, Johannes Berg wrote:
> Well, I'm not sure I'm the right person to look at this, I'm very
> unfamiliar with the code in question. For all I care we can put it in
> and revert/fixup when we get bug reports from it.

Thanks. Let's do it if no one NACK.

-yi

Re: [RFC PATCH] mac80211 : Association with 11n hidden ssid ap.

[Tomas Winkler]

On Tue, May 13, 2008 at 11:35 AM, Johannes Berg
<johannes@sipsolutions.net> wrote:
>
>  > Johannes, can you please take a look at this patch? The original code
>  > looks like a shortcut to start authentication/association when all the
>  > three parameters (BSSID/SSID/CHANNEL) are provided. But this is not
>  > sufficient in the case of associate with an 11N hidden SSID AP. The 11n
>  > and wmm information must be retrieved by an active probe request. Not
>  > doing so will cause the 11N AP refuse to associate with the client.
>
>
>
> > > -   if (!(ifsta->flags & (IEEE80211_STA_AUTO_SSID_SEL |
>  > > -       IEEE80211_STA_AUTO_BSSID_SEL | IEEE80211_STA_AUTO_CHANNEL_SEL))) {
>  > > -           ifsta->state = IEEE80211_AUTHENTICATE;
>  > > -           ieee80211_sta_reset_auth(dev, ifsta);
>  > > -           return 0;
>  > > -   }
>  > > -
>  > >     spin_lock_bh(&local->sta_bss_lock);
>
>  Well, I'm not sure I'm the right person to look at this, I'm very
>  unfamiliar with the code in question. For all I care we can put it in
>  and revert/fixup when we get bug reports from it.
>

You should always had in hand at least one probe response before
attempting association as mot all information elements are present in
beacons.  This is not only case for 11n but for QoS in general.
I would suggest that association process in BSS will always start with
sending probe request.

Tomas


>  johannes
>

Re: [RFC PATCH] mac80211 : Association with 11n hidden ssid ap.

[John W. Linville]

On Tue, May 13, 2008 at 09:26:35AM +0800, Zhu Yi wrote:
> On Fri, 2008-05-09 at 09:35 -0700, Abhijeet Kolekar wrote:
> > This patch fixes the association problem with 11n hidden ssid ap.
> > Patch fixes the problem of associating with hidden ssid when
> > all three parameters ap,essid and channel are given to iwconfig.
> > This patch removes the condition of checking three parameters
> > and always checks for bss in bss list while associating.
> 
> Johannes, can you please take a look at this patch? The original code
> looks like a shortcut to start authentication/association when all the
> three parameters (BSSID/SSID/CHANNEL) are provided. But this is not
> sufficient in the case of associate with an 11N hidden SSID AP. The 11n
> and wmm information must be retrieved by an active probe request. Not
> doing so will cause the 11N AP refuse to associate with the client.

I'll ACK this based on the above explanation and because I don't
think it will do any harm. :-)

John
-- 
John W. Linville
linville@tuxdriver.com