Re: [PATCH stable] libertas: Extend CMD_MESH_CONFIG to get and set persistent mesh default params.

Re: [PATCH stable] libertas: Extend CMD_MESH_CONFIG to get and set persistent mesh default params.

[David Woodhouse]

On Thu, 2008-05-15 at 11:01 -0700, Brian Cavagnolo wrote:
> This patch is based on a patch from Shailendra Govardhan.  It introduces
> several new iwprivs: {get,set}_bootflag {get,set}_boottime {get,set}_def_chan
> {get,set}_def_protid {get,set}_def_metid {get,set}_def_meshcap
> {get,set}_def_meshid.  These commands are only supported on Marvell hardware
> that implements persistent defaults, such as the OLPC Active Antenna.
> Accordingly, this patch may not be suitable for upstream merging.
> 
> See http://dev.laptop.org/ticket/6823 for minimal testing results and known
> issues.  See http://www.laptop.org/teamwiki/index.php/Tech:Wireless#Firmware_image_which_stores_the_mesh_parameters_in_flash for iwpriv documentation.
> 
> Signed-off-by: Brian Cavagnolo <brian@cozybit.com>
> ---

Hm. I was intending to veto the addition of any more private ioctls to
the olpc tree, because they all need fixing to use cfg80211 or something
else upstream, and we only make pain for ourselves by adding to the
divergence -- adding new APIs to userspace when we _know_ are going to
have to change them is just silly.

But this is the _one_ thing which might actually be OK to do with a
private ioctl, since it's very hardware-specific. Unlike like all the
mesh-mangling stuff where we really ought to be compatible with o11s.

So maybe, just maybe, we _can_ do this with iwpriv and push that
upstream.

If you want to revamp the patch to apply to the upstream kernel and see
what people think of it, go ahead.

-- 
dwmw2

Re: [PATCH stable] libertas: Extend CMD_MESH_CONFIG to get and set persistent mesh default params.

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 1050 bytes --]

On Fri, 2008-05-16 at 15:09 +0100, David Woodhouse wrote:
> On Thu, 2008-05-15 at 11:01 -0700, Brian Cavagnolo wrote:
> > This patch is based on a patch from Shailendra Govardhan.  It introduces
> > several new iwprivs: {get,set}_bootflag {get,set}_boottime {get,set}_def_chan
> > {get,set}_def_protid {get,set}_def_metid {get,set}_def_meshcap
> > {get,set}_def_meshid.  These commands are only supported on Marvell hardware
> > that implements persistent defaults, such as the OLPC Active Antenna.
> > Accordingly, this patch may not be suitable for upstream merging.

> But this is the _one_ thing which might actually be OK to do with a
> private ioctl, since it's very hardware-specific. Unlike like all the
> mesh-mangling stuff where we really ought to be compatible with o11s.
> 
> So maybe, just maybe, we _can_ do this with iwpriv and push that
> upstream.

Maybe we do, after all, need an iwpriv equivalent in cfg80211/nl80211 so
that we can kill wext at some point.

Or maybe this should be in sysfs or so?

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

Re: [PATCH stable] libertas: Extend CMD_MESH_CONFIG to get and set persistent mesh default params.

[Stefanik Gábor]

On Fri, May 16, 2008 at 4:50 PM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> On Fri, 2008-05-16 at 15:09 +0100, David Woodhouse wrote:
>> On Thu, 2008-05-15 at 11:01 -0700, Brian Cavagnolo wrote:
>> > This patch is based on a patch from Shailendra Govardhan.  It introduces
>> > several new iwprivs: {get,set}_bootflag {get,set}_boottime {get,set}_def_chan
>> > {get,set}_def_protid {get,set}_def_metid {get,set}_def_meshcap
>> > {get,set}_def_meshid.  These commands are only supported on Marvell hardware
>> > that implements persistent defaults, such as the OLPC Active Antenna.
>> > Accordingly, this patch may not be suitable for upstream merging.
>
>> But this is the _one_ thing which might actually be OK to do with a
>> private ioctl, since it's very hardware-specific. Unlike like all the
>> mesh-mangling stuff where we really ought to be compatible with o11s.
>>
>> So maybe, just maybe, we _can_ do this with iwpriv and push that
>> upstream.
>
> Maybe we do, after all, need an iwpriv equivalent in cfg80211/nl80211 so
> that we can kill wext at some point.
>
> Or maybe this should be in sysfs or so?
>
> johannes
>

Or maybe in configfs? That's a better place for configuration options.
(BTW rt2x00 uses debugfs as an iwpriv replacement, so that's another
possibility.)

-- 
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)

Re: [PATCH stable] libertas: Extend CMD_MESH_CONFIG to get and set persistent mesh default params.

[Dan Williams]

On Fri, 2008-05-16 at 17:51 +0200, Stefanik G=C3=A1bor wrote:
> On Fri, May 16, 2008 at 4:50 PM, Johannes Berg
> <johannes@sipsolutions.net> wrote:
> > On Fri, 2008-05-16 at 15:09 +0100, David Woodhouse wrote:
> >> On Thu, 2008-05-15 at 11:01 -0700, Brian Cavagnolo wrote:
> >> > This patch is based on a patch from Shailendra Govardhan.  It in=
troduces
> >> > several new iwprivs: {get,set}_bootflag {get,set}_boottime {get,=
set}_def_chan
> >> > {get,set}_def_protid {get,set}_def_metid {get,set}_def_meshcap
> >> > {get,set}_def_meshid.  These commands are only supported on Marv=
ell hardware
> >> > that implements persistent defaults, such as the OLPC Active Ant=
enna.
> >> > Accordingly, this patch may not be suitable for upstream merging=
=2E
> >
> >> But this is the _one_ thing which might actually be OK to do with =
a
> >> private ioctl, since it's very hardware-specific. Unlike like all =
the
> >> mesh-mangling stuff where we really ought to be compatible with o1=
1s.
> >>
> >> So maybe, just maybe, we _can_ do this with iwpriv and push that
> >> upstream.
> >
> > Maybe we do, after all, need an iwpriv equivalent in cfg80211/nl802=
11 so
> > that we can kill wext at some point.
> >
> > Or maybe this should be in sysfs or so?
> >
> > johannes
> >
>=20
> Or maybe in configfs? That's a better place for configuration options=
=2E
> (BTW rt2x00 uses debugfs as an iwpriv replacement, so that's another
> possibility.)

I keep proposing debugfs too, but in some cases the commands aren't jus=
t
for poking around with stuff.  configfs is probably a better answer to
tweakables that aren't just ricer-geekporn.

Dan

--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html