From: Dan Williams <dcbw@redhat.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
libertas-dev@lists.infradead.org,
Brian Cavagnolo <brian@cozybit.com>,
Javier Cardona <javier@cozybit.com>
Subject: Re: libertas: fix command timeout after firmware failure
Date: Tue, 13 May 2008 12:19:28 -0400 [thread overview]
Message-ID: <1210695568.9976.3.camel@localhost.localdomain> (raw)
In-Reply-To: <1210683299.3582.240.camel@pmac.infradead.org>
On Tue, 2008-05-13 at 13:54 +0100, David Woodhouse wrote:
> From: Brian Cavagnolo <brian@cozybit.com>
>
> This is a fix for OLPC ticket #6586: "SCAN command fails, timer doesn't
> fire". In fact, the timer was firing; the problem was that the dnld_sent
> state variable was not being updated after the timer expired, so
> lbs_execute_next_command was not being called.
>
> Signed-off-by: Brian Cavagnolo <brian@cozybit.com>
> Signed-off-by: Javier Cardona <javier@cozybit.com>
> Signed-off-by: David Woodhouse <dwmw2@infradead.org>
>
> ---
> Bug fix, for 2.6.26 please.
>
> --- a/drivers/net/wireless/libertas/main.c
> +++ b/drivers/net/wireless/libertas/main.c
> @@ -756,6 +756,7 @@ static int lbs_thread(void *data)
> priv->nr_retries = 0;
> } else {
> priv->cur_cmd = NULL;
> + priv->dnld_sent = DNLD_RES_RECEIVED;
> lbs_pr_info("requeueing command %x due to timeout (#%d)\n",
> le16_to_cpu(cmdnode->cmdbuf->command), priv->nr_retries);
We really need to kill dnld_sent.
Dan
next prev parent reply other threads:[~2008-05-13 16:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-13 12:54 libertas: fix command timeout after firmware failure David Woodhouse
2008-05-13 14:01 ` Holger Schurig
2008-05-13 16:19 ` Dan Williams [this message]
2008-05-13 16:25 ` David Woodhouse
2008-05-14 6:57 ` Holger Schurig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1210695568.9976.3.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=brian@cozybit.com \
--cc=dwmw2@infradead.org \
--cc=javier@cozybit.com \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox