* libertas: fix command timeout after firmware failure
@ 2008-05-13 12:54 David Woodhouse
2008-05-13 14:01 ` Holger Schurig
2008-05-13 16:19 ` Dan Williams
0 siblings, 2 replies; 5+ messages in thread
From: David Woodhouse @ 2008-05-13 12:54 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, libertas-dev, Brian Cavagnolo, Javier Cardona
From: Brian Cavagnolo <brian@cozybit.com>
This is a fix for OLPC ticket #6586: "SCAN command fails, timer doesn't
fire". In fact, the timer was firing; the problem was that the dnld_sent
state variable was not being updated after the timer expired, so
lbs_execute_next_command was not being called.
Signed-off-by: Brian Cavagnolo <brian@cozybit.com>
Signed-off-by: Javier Cardona <javier@cozybit.com>
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
---
Bug fix, for 2.6.26 please.
--- a/drivers/net/wireless/libertas/main.c
+++ b/drivers/net/wireless/libertas/main.c
@@ -756,6 +756,7 @@ static int lbs_thread(void *data)
priv->nr_retries = 0;
} else {
priv->cur_cmd = NULL;
+ priv->dnld_sent = DNLD_RES_RECEIVED;
lbs_pr_info("requeueing command %x due to timeout (#%d)\n",
le16_to_cpu(cmdnode->cmdbuf->command), priv->nr_retries);
--
dwmw2
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: libertas: fix command timeout after firmware failure
2008-05-13 12:54 libertas: fix command timeout after firmware failure David Woodhouse
@ 2008-05-13 14:01 ` Holger Schurig
2008-05-13 16:19 ` Dan Williams
1 sibling, 0 replies; 5+ messages in thread
From: Holger Schurig @ 2008-05-13 14:01 UTC (permalink / raw)
To: linux-wireless
Cc: David Woodhouse, linville, libertas-dev, Brian Cavagnolo,
Javier Cardona
> Signed-off-by: Brian Cavagnolo <brian@cozybit.com>
> Signed-off-by: Javier Cardona <javier@cozybit.com>
> Signed-off-by: David Woodhouse <dwmw2@infradead.org>
Not sure if you need it, but:
Acked-by: Holger Schurig <hs4233@mail.mn-solutions.de>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: libertas: fix command timeout after firmware failure
2008-05-13 12:54 libertas: fix command timeout after firmware failure David Woodhouse
2008-05-13 14:01 ` Holger Schurig
@ 2008-05-13 16:19 ` Dan Williams
2008-05-13 16:25 ` David Woodhouse
1 sibling, 1 reply; 5+ messages in thread
From: Dan Williams @ 2008-05-13 16:19 UTC (permalink / raw)
To: David Woodhouse
Cc: linville, linux-wireless, libertas-dev, Brian Cavagnolo,
Javier Cardona
On Tue, 2008-05-13 at 13:54 +0100, David Woodhouse wrote:
> From: Brian Cavagnolo <brian@cozybit.com>
>
> This is a fix for OLPC ticket #6586: "SCAN command fails, timer doesn't
> fire". In fact, the timer was firing; the problem was that the dnld_sent
> state variable was not being updated after the timer expired, so
> lbs_execute_next_command was not being called.
>
> Signed-off-by: Brian Cavagnolo <brian@cozybit.com>
> Signed-off-by: Javier Cardona <javier@cozybit.com>
> Signed-off-by: David Woodhouse <dwmw2@infradead.org>
>
> ---
> Bug fix, for 2.6.26 please.
>
> --- a/drivers/net/wireless/libertas/main.c
> +++ b/drivers/net/wireless/libertas/main.c
> @@ -756,6 +756,7 @@ static int lbs_thread(void *data)
> priv->nr_retries = 0;
> } else {
> priv->cur_cmd = NULL;
> + priv->dnld_sent = DNLD_RES_RECEIVED;
> lbs_pr_info("requeueing command %x due to timeout (#%d)\n",
> le16_to_cpu(cmdnode->cmdbuf->command), priv->nr_retries);
We really need to kill dnld_sent.
Dan
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: libertas: fix command timeout after firmware failure
2008-05-13 16:19 ` Dan Williams
@ 2008-05-13 16:25 ` David Woodhouse
2008-05-14 6:57 ` Holger Schurig
0 siblings, 1 reply; 5+ messages in thread
From: David Woodhouse @ 2008-05-13 16:25 UTC (permalink / raw)
To: Dan Williams
Cc: linville, linux-wireless, libertas-dev, Brian Cavagnolo,
Javier Cardona
On Tue, 2008-05-13 at 12:19 -0400, Dan Williams wrote:
> On Tue, 2008-05-13 at 13:54 +0100, David Woodhouse wrote:
> > From: Brian Cavagnolo <brian@cozybit.com>
> >
> > This is a fix for OLPC ticket #6586: "SCAN command fails, timer doesn't
> > fire". In fact, the timer was firing; the problem was that the dnld_sent
> > state variable was not being updated after the timer expired, so
> > lbs_execute_next_command was not being called.
> >
> > Signed-off-by: Brian Cavagnolo <brian@cozybit.com>
> > Signed-off-by: Javier Cardona <javier@cozybit.com>
> > Signed-off-by: David Woodhouse <dwmw2@infradead.org>
> >
> > ---
> > Bug fix, for 2.6.26 please.
> >
> > --- a/drivers/net/wireless/libertas/main.c
> > +++ b/drivers/net/wireless/libertas/main.c
> > @@ -756,6 +756,7 @@ static int lbs_thread(void *data)
> > priv->nr_retries = 0;
> > } else {
> > priv->cur_cmd = NULL;
> > + priv->dnld_sent = DNLD_RES_RECEIVED;
> > lbs_pr_info("requeueing command %x due to timeout (#%d)\n",
> > le16_to_cpu(cmdnode->cmdbuf->command), priv->nr_retries);
>
> We really need to kill dnld_sent.
Yes. I almost managed it at one point but I think I wanted to get set up
to set on CF and SD hardware before I really did it.
--
dwmw2
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-05-14 7:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-13 12:54 libertas: fix command timeout after firmware failure David Woodhouse
2008-05-13 14:01 ` Holger Schurig
2008-05-13 16:19 ` Dan Williams
2008-05-13 16:25 ` David Woodhouse
2008-05-14 6:57 ` Holger Schurig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).