From: Pavel Roskin <proski@gnu.org>
To: John Daiker <daikerjohn@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: First patch to mrv8k driver?
Date: Wed, 14 May 2008 00:37:37 -0400 [thread overview]
Message-ID: <1210739857.2721.51.camel@rd> (raw)
In-Reply-To: <482A3961.2010906@gmail.com>
On Tue, 2008-05-13 at 17:59 -0700, John Daiker wrote:
> Hey All,
>
> My first patch for the mrv8k driver. My machine locks up when I try to
> load a firmware, so I'm not sure if this patch helps anybody or not.
I don't see any changes for mrv_reg_read32() claimed in the description.
In fact, I don't see any changes to the code except comments and
messages. I don't see how it can help against lockups, unless you
missed some part of the patch.
You may want to spell check your patch, including the description,
especially if the patch is fixing spelling mistakes made by others.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2008-05-14 4:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-14 0:59 First patch to mrv8k driver? John Daiker
2008-05-14 4:37 ` Pavel Roskin [this message]
2008-05-14 13:08 ` Markus Becker
2008-05-14 13:21 ` Johannes Berg
2008-05-14 17:56 ` John Daiker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1210739857.2721.51.camel@rd \
--to=proski@gnu.org \
--cc=daikerjohn@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).