From: Dan Williams <dcbw@redhat.com>
To: Masakazu Mokuno <mokuno@sm.sony.co.jp>
Cc: linux-wireless@vger.kernel.org, yi.zhu@intel.com
Subject: Re: [PATCH] wireless: Create 'device' symlink in sysfs
Date: Wed, 14 May 2008 11:26:33 -0400 [thread overview]
Message-ID: <1210778793.28532.0.camel@localhost.localdomain> (raw)
In-Reply-To: <20080514124516.A06B.40F06B3A@sm.sony.co.jp>
On Wed, 2008-05-14 at 14:16 +0900, Masakazu Mokuno wrote:
> Some network interfaces of the wireless drivers lack the 'device'
> symlink in sysfs.
> This patch lets the drivers create the links.
>
> Signed-off-by: Masakazu Mokuno <mokuno@sm.sony.co.jp>
Libertas parts:
Acked-by: Dan Williams <dcbw@redhat.com>
but in general, this is a Good Thing, since it would allow HAL to match
the device up with it's parent.
> ---
> drivers/net/wireless/airo.c | 1 +
> drivers/net/wireless/ipw2200.c | 1 +
> drivers/net/wireless/libertas/main.c | 1 +
> 3 files changed, 3 insertions(+)
>
> --- a/drivers/net/wireless/airo.c
> +++ b/drivers/net/wireless/airo.c
> @@ -2668,6 +2668,7 @@ static struct net_device *init_wifidev(s
> dev->irq = ethdev->irq;
> dev->base_addr = ethdev->base_addr;
> dev->wireless_data = ethdev->wireless_data;
> + SET_NETDEV_DEV(dev, ethdev->dev.parent);
> memcpy(dev->dev_addr, ethdev->dev_addr, dev->addr_len);
> err = register_netdev(dev);
> if (err<0) {
> --- a/drivers/net/wireless/ipw2200.c
> +++ b/drivers/net/wireless/ipw2200.c
> @@ -11584,6 +11584,7 @@ static int ipw_prom_alloc(struct ipw_pri
> priv->prom_net_dev->hard_start_xmit = ipw_prom_hard_start_xmit;
>
> priv->prom_priv->ieee->iw_mode = IW_MODE_MONITOR;
> + SET_NETDEV_DEV(priv->prom_net_dev, &priv->pci_dev->dev);
>
> rc = register_netdev(priv->prom_net_dev);
> if (rc) {
> --- a/drivers/net/wireless/libertas/main.c
> +++ b/drivers/net/wireless/libertas/main.c
> @@ -1566,6 +1566,7 @@ static int lbs_add_rtap(struct lbs_priva
> rtap_dev->hard_start_xmit = lbs_rtap_hard_start_xmit;
> rtap_dev->set_multicast_list = lbs_set_multicast_list;
> rtap_dev->priv = priv;
> + SET_NETDEV_DEV(rtap_dev, priv->dev->dev.parent);
>
> ret = register_netdev(rtap_dev);
> if (ret) {
>
prev parent reply other threads:[~2008-05-14 15:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-14 5:16 [PATCH] wireless: Create 'device' symlink in sysfs Masakazu Mokuno
2008-05-14 15:26 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1210778793.28532.0.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=mokuno@sm.sony.co.jp \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox