Re: [PATCH 5/5] mac80211: move TX info into skb->cb

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 1005 bytes --]


> > > A number of fixes were done by Ivo, as well as the rt2x00 part
> > > of this patch.
> > 
> > I mangled it a bit though so you may want to check it, mac80211 now sets
> > REQ_TX_STATUS so you can use that for status reporting, but you can't
> > use it for queue kicking at least not in the future when mac80211 might
> > not set it on all frames.
> 
> Well queue kicking from driver to mac80211 is in rt2x00 based on txdone
> events on a particular queue. (When frame was succesfully transmitted
> and is no longer full, then the queue will be awakened by rt2x00).

Yeah, but the patch you had sent me was removing the "driver generated"
flag, and I kept that around now for this purpose.

I have thought about this a bit, you may want to wait wrt. fragments
because I'm going to rewrite fragmentation, and then we could change the
mac80211/driver API to hand the driver an skb with all the fragments at
once instead of handing it each fragment one by one, thoughts?

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]