iwlwifi Makefile issue in compat-wireless-2008-05-18

iwlwifi Makefile issue in compat-wireless-2008-05-18

[John Goulah]

Hello,

 Went to install the new version and found that it wasn't installing
the iwl4965 driver.  I did a diff against my last good version (back
in April so not sure how long its been like this)


I noticed this change, and when I reverted it back, the driver built fine:


compat-wireless-2008-05-18$ diff -u
/usr/local/src/compat-wireless-2008-04-08/drivers/net/wireless/Makefile
 drivers/net/wireless/Makefile
--- /usr/local/src/compat-wireless-2008-04-08/drivers/net/wireless/Makefile
    2008-04-08 00:12:21.000000000 -0400
+++ drivers/net/wireless/Makefile       2008-05-18 00:11:30.000000000 -0400
@@ -23,12 +23,9 @@

 obj-$(CONFIG_ADM8211)  += adm8211.o

-obj-$(CONFIG_IWL3945)  += iwlwifi/
-obj-$(CONFIG_IWL4965)  += iwlwifi/
+obj-$(CONFIG_IWLWIFI)  += iwlwifi/
 obj-$(CONFIG_RT2X00)   += rt2x00/





Hope this helps to straighten this issue out.


Thanks,
John

Re: iwlwifi Makefile issue in compat-wireless-2008-05-18

[Zhu Yi]

On Sun, 2008-05-18 at 14:43 -0400, John Goulah wrote:
> Hello,
> 
>  Went to install the new version and found that it wasn't installing
> the iwl4965 driver.  I did a diff against my last good version (back
> in April so not sure how long its been like this)

We introduced the virtual CONFIG_IWLWIFI in recent wireless-testing. It
is a tristate when either CONFIG_IWL3945 or CONFIG_IWLCORE is selected.
It doesn't appear in the old kernel you are compiling against. Maybe
someone need to make a patch for Kconfig in compact-wireless?

Thanks,
-yi

> I noticed this change, and when I reverted it back, the driver built fine:
> 
> 
> compat-wireless-2008-05-18$ diff -u
> /usr/local/src/compat-wireless-2008-04-08/drivers/net/wireless/Makefile
>  drivers/net/wireless/Makefile
> --- /usr/local/src/compat-wireless-2008-04-08/drivers/net/wireless/Makefile
>     2008-04-08 00:12:21.000000000 -0400
> +++ drivers/net/wireless/Makefile       2008-05-18 00:11:30.000000000 -0400
> @@ -23,12 +23,9 @@
> 
>  obj-$(CONFIG_ADM8211)  += adm8211.o
> 
> -obj-$(CONFIG_IWL3945)  += iwlwifi/
> -obj-$(CONFIG_IWL4965)  += iwlwifi/
> +obj-$(CONFIG_IWLWIFI)  += iwlwifi/
>  obj-$(CONFIG_RT2X00)   += rt2x00/
> 
> 
> 
> 
> 
> Hope this helps to straighten this issue out.
> 
> 
> Thanks,
> John
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: iwlwifi Makefile issue in compat-wireless-2008-05-18

[John Goulah]

On Sun, May 18, 2008 at 11:41 PM, Zhu Yi <yi.zhu@intel.com> wrote:
> On Sun, 2008-05-18 at 14:43 -0400, John Goulah wrote:
>> Hello,
>>
>>  Went to install the new version and found that it wasn't installing
>> the iwl4965 driver.  I did a diff against my last good version (back
>> in April so not sure how long its been like this)
>
> We introduced the virtual CONFIG_IWLWIFI in recent wireless-testing. It
> is a tristate when either CONFIG_IWL3945 or CONFIG_IWLCORE is selected.
> It doesn't appear in the old kernel you are compiling against. Maybe
> someone need to make a patch for Kconfig in compact-wireless?
>


Thats odd, my kernel is fairly new -- 2.6.24.4

I custom compiled it, and I dont see anything related to IWL  in my
.config file strangely enough.  I guess its possible my .config got
out of sync somehow, or is this what you would consider "old" ?


Thanks!
John

Re: iwlwifi Makefile issue in compat-wireless-2008-05-18

[Zhu Yi]

On Mon, 2008-05-19 at 09:10 -0400, John Goulah wrote:
> 
> Thats odd, my kernel is fairly new -- 2.6.24.4
> 
> I custom compiled it, and I dont see anything related to IWL  in my
> .config file strangely enough.  I guess its possible my .config got
> out of sync somehow, or is this what you would consider "old" ?

Yup, .24 is old. The patch will make its way to .26 (not released yet).

Thanks,
-yi

Re: iwlwifi Makefile issue in compat-wireless-2008-05-18

[John Goulah]

On Mon, May 19, 2008 at 9:01 PM, Zhu Yi <yi.zhu@intel.com> wrote:
> On Mon, 2008-05-19 at 09:10 -0400, John Goulah wrote:
>>
>> Thats odd, my kernel is fairly new -- 2.6.24.4
>>
>> I custom compiled it, and I dont see anything related to IWL  in my
>> .config file strangely enough.  I guess its possible my .config got
>> out of sync somehow, or is this what you would consider "old" ?
>
> Yup, .24 is old. The patch will make its way to .26 (not released yet).
>



Ok,  I assume you mean the patch for the kernel config that allows
this all to work?

Would that mean you're not supporting compiling on any kernel older
than 2.6.26 with this change?

Thanks so much,
John

Re: iwlwifi Makefile issue in compat-wireless-2008-05-18

[Zhu Yi]

On Mon, 2008-05-19 at 21:23 -0400, John Goulah wrote:
> Ok,  I assume you mean the patch for the kernel config that allows
> this all to work?

I mean the recent patch introduces CONFIG_IWLWIFI.

> Would that mean you're not supporting compiling on any kernel older
> than 2.6.26 with this change?

I'd suggest we patch compat-wireless like this (given the fact it
doesn't make use of Kconfig).

Thanks,
-yi

--- config.mk	2008-05-20 11:46:55.000000000 +0800
+++ /tmp/config.mk	2008-05-20 11:46:49.000000000 +0800
@@ -30,6 +30,7 @@ ifneq ($(CONFIG_PCI),)
 
 CONFIG_ATH5K=m
 CONFIG_ATH5K_DEBUG=n
+CONFIG_IWLWIFI=m
 CONFIG_IWLCORE=m
 CONFIG_IWL3945=m
 CONFIG_IWL4965=m

Re: iwlwifi Makefile issue in compat-wireless-2008-05-18

[Luis R. Rodriguez]

On Mon, May 19, 2008 at 8:48 PM, Zhu Yi <yi.zhu@intel.com> wrote:
> On Mon, 2008-05-19 at 21:23 -0400, John Goulah wrote:
>> Ok,  I assume you mean the patch for the kernel config that allows
>> this all to work?
>
> I mean the recent patch introduces CONFIG_IWLWIFI.
>
>> Would that mean you're not supporting compiling on any kernel older
>> than 2.6.26 with this change?
>
> I'd suggest we patch compat-wireless like this (given the fact it
> doesn't make use of Kconfig).
>
> Thanks,
> -yi
>
> --- config.mk   2008-05-20 11:46:55.000000000 +0800
> +++ /tmp/config.mk      2008-05-20 11:46:49.000000000 +0800
> @@ -30,6 +30,7 @@ ifneq ($(CONFIG_PCI),)
>
>  CONFIG_ATH5K=m
>  CONFIG_ATH5K_DEBUG=n
> +CONFIG_IWLWIFI=m
>  CONFIG_IWLCORE=m
>  CONFIG_IWL3945=m
>  CONFIG_IWL4965=m

Applied on compat-wireless.

thanks,

  Luis