From: Pavel Roskin <proski@gnu.org>
To: Michael Buesch <mb@bu3sch.de>
Cc: John Linville <linville@tuxdriver.com>,
Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org, bcm43xx-dev@lists.berlios.de
Subject: Re: [PATCH] b43: Upload both beacon templates on initial load
Date: Tue, 20 May 2008 19:29:35 -0400 [thread overview]
Message-ID: <1211326175.21859.10.camel@dv> (raw)
In-Reply-To: <200805201216.29134.mb@bu3sch.de>
On Tue, 2008-05-20 at 12:16 +0200, Michael Buesch wrote:
> This updates the beacon template code to upload both templates,
> if we never uploaded one before.
=2E..
> + bool beacon_templates_virgin; /* Never wrote the templates? */
=2E..
> @@ -4164,12 +4191,15 @@ static int b43_op_start(struct ieee80211
> * and mac80211 reconfiguring it. */
> memset(wl->bssid, 0, ETH_ALEN);
> memset(wl->mac_addr, 0, ETH_ALEN);
> wl->filter_flags =3D 0;
> wl->radiotap_enabled =3D 0;
> b43_qos_clear(wl);
> + wl->beacon0_uploaded =3D 0;
> + wl->beacon1_uploaded =3D 0;
> + wl->beacon_templates_virgin =3D 1;
=EF=BB=BFJust a hint. You may want to revert the logic, so that you st=
art with
0 and set the variable to 1 as something substantial happens. You can
introduce more states later if required, or count the upload events.
This way, it would be beacon_templates_loaded or
beacon_templates_touched.
The human brain is better at understanding positive meanings. "virgin"
means that something did _not_ happen, and it's not like it's very
valuable per se, at least for beacon templates :-)
I worked on code full of things like HAVE_NO_CURSES_H and DISABLE_COLOR=
,
and it wasn't fun.
--=20
Regards,
Pavel Roskin
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-05-20 23:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-20 10:16 [PATCH] b43: Upload both beacon templates on initial load Michael Buesch
2008-05-20 23:29 ` Pavel Roskin [this message]
2008-05-21 10:00 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1211326175.21859.10.camel@dv \
--to=proski@gnu.org \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).