Linux wireless drivers development
 help / color / mirror / Atom feed
From: Dan Williams <dcbw@redhat.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Tomas Winkler <tomasw@gmail.com>,
	Vincent C Jones <v.jones@networkingunlimited.com>,
	linux-wireless@vger.kernel.org,
	Emmanuel Grumbach <egrumbach@gmail.com>
Subject: Re: iwl4965 - wpa_supplicant can't see 5Ghz frequencies - 2.6.26-rc1 kernel
Date: Thu, 22 May 2008 15:30:12 -0400	[thread overview]
Message-ID: <1211484612.28022.31.camel@localhost.localdomain> (raw)
In-Reply-To: <1211483568.3698.66.camel@johannes.berg>

On Thu, 2008-05-22 at 21:12 +0200, Johannes Berg wrote:
> > > wpa_supplicant cannot handle A-band channel #s.  Thus, with the previous
> > > code, the FREQ+frequency was sent first, and the FREQ+channel was sent
> > > second.  Sending the FREQ+channel second made the supplicant overwrite
> > > the value it already parsed from the FREQ+frequency for that BSSID.  But
> > > since the supplicant can't handle A-band channel #s, you end up with 0.
> > >
> > > Reversing the order of these two makes it work, but it's a total hack.
> > > That may be what's needed right now though until everyone fixes their
> > > supplicant.  There's overlap on A-band channels 7 - 12 (5035MHz ->
> > > 5060MHz) with B/G band channel #s.  Obviously WEXT falls over here
> > > because the band isn't passed.
> > >
> > > But what's the best fix to the supplicant?  It could just parse A-band
> > > channels and where the numbers overlap, assume B/G band.  Or, it could
> > > be patched to prefer FREQ+frequency over FREQ+channel if it received
> > > both.  That's probably the best solution.
> 
> Fun. How about it we just make wpa supplicant ignore FREQ/channel
> completely if it uses FREQ/frequency anyway?

Can't because some drivers send channel and not frequency.  Yeah, we
could fix all the drivers, but that doesn't help people running latest
supplicant on older kernels.

atmel.c
zd1201.c
wl3501_cs.c
linux-wlan-ng (somewhat unclear but probably)

Dan

> > Actually we've also tried to removing FREQ+channel part and it has
> > worked. So wpa_supplicant won't get into this dilemma.
> 
> Makes sense.
> 
> > Patch that broke it is below so  I guess the bug is in everything form
> > 2.6.25 and up.
> > '
> > commit 8318d78a44d49ac1edf2bdec7299de3617c4232e
> > Author: Johannes Berg <johannes@sipsolutions.net>
> > Date:   Thu Jan 24 19:38:38 2008 +0100
> > 
> >     cfg80211 API for channels/bitrates, mac80211 and driver conversion
> > '
> 
> Yeah, sorry about that. Once more, bitten by the assumption wext was
> useful and people would implement it properly.
> 
> johannes


  reply	other threads:[~2008-05-22 19:30 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-09 16:57 iwl4965 - wpa_supplicant can't see 5Ghz frequencies - 2.6.26-rc1 kernel Vincent C Jones
2008-05-09 21:23 ` Tomas Winkler
2008-05-09 23:41   ` Vincent C Jones
2008-05-10  0:12     ` Tomas Winkler
2008-05-10  2:36       ` Vincent C Jones
2008-05-10 14:39       ` Vincent C Jones
2008-05-10 15:46         ` Vincent C Jones
2008-05-10 18:56           ` Tomas Winkler
2008-05-10 21:48             ` Vincent C Jones
2008-05-10 22:06               ` Tomas Winkler
2008-05-11  2:49                 ` Vincent C Jones
2008-05-12 16:50                   ` Tomas Winkler
2008-05-12 18:37                     ` Vincent C Jones
2008-05-22 16:53                       ` Tomas Winkler
2008-05-22 17:42                         ` Dann Church
2008-05-22 17:54                           ` Tomas Winkler
2008-05-24 11:03                             ` Dann Church
2008-05-22 17:56                         ` Johannes Berg
2008-05-22 17:58                           ` Tomas Winkler
2008-05-22 18:34                           ` Dan Williams
2008-05-22 18:50                             ` Pavel Roskin
2008-05-22 19:18                               ` Dan Williams
2008-05-22 19:21                                 ` Johannes Berg
2008-05-22 18:51                             ` Tomas Winkler
2008-05-22 19:12                               ` Johannes Berg
2008-05-22 19:30                                 ` Dan Williams [this message]
2008-05-22 19:34                                   ` Johannes Berg
2008-05-22 20:56                                     ` Tomas Winkler
2008-05-22 21:09                                       ` Johannes Berg
2008-05-22 22:07                                       ` Dan Williams
2008-05-22 18:22                         ` Dan Williams
2008-05-22 19:16                           ` Johannes Berg
2008-05-22 22:33                         ` Vincent C Jones
2008-05-22 22:50                           ` Tomas Winkler
2008-05-22 23:28                             ` Vincent C Jones
2008-05-10 17:06         ` Tomas Winkler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1211484612.28022.31.camel@localhost.localdomain \
    --to=dcbw@redhat.com \
    --cc=egrumbach@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=tomasw@gmail.com \
    --cc=v.jones@networkingunlimited.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox