Linux wireless drivers development
 help / color / mirror / Atom feed
From: Dan Williams <dcbw@redhat.com>
To: Tomas Winkler <tomas.winkler@intel.com>
Cc: linville@tuxdriver.com, johannes@sipsolutions.net,
	yi.zhu@intel.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/1] mac80211: reorder channel and freq reporting in wext scan report
Date: Fri, 23 May 2008 07:36:48 -0400	[thread overview]
Message-ID: <1211542608.30036.8.camel@localhost.localdomain> (raw)
In-Reply-To: <1211495796-2881-1-git-send-email-tomas.winkler@intel.com>

On Fri, 2008-05-23 at 01:36 +0300, Tomas Winkler wrote:
> This patch switch order of channel and freq (SIOCGIWFREQ) reports
> in scan results in order to overcome wpa_supplicant inability
> to handle channel numbers in 5.2Ghz band.
> Wext reporting channel number is ambiguous as channels 7-12 (802.11j)
> exist on both bands.
> 
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>

Acked-by: Dan Williams <dcbw@redhat.com>

> ---
>  net/mac80211/mlme.c |    9 ++++-----
>  1 files changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
> index 7cfd12e..c7eca4d 100644
> --- a/net/mac80211/mlme.c
> +++ b/net/mac80211/mlme.c
> @@ -4095,18 +4095,17 @@ ieee80211_sta_scan_result(struct net_device *dev,
>  
>  	memset(&iwe, 0, sizeof(iwe));
>  	iwe.cmd = SIOCGIWFREQ;
> -	iwe.u.freq.m = bss->freq;
> -	iwe.u.freq.e = 6;
> +	iwe.u.freq.m = ieee80211_frequency_to_channel(bss->freq);
> +	iwe.u.freq.e = 0;
>  	current_ev = iwe_stream_add_event(current_ev, end_buf, &iwe,
>  					  IW_EV_FREQ_LEN);
>  
>  	memset(&iwe, 0, sizeof(iwe));
>  	iwe.cmd = SIOCGIWFREQ;
> -	iwe.u.freq.m = ieee80211_frequency_to_channel(bss->freq);
> -	iwe.u.freq.e = 0;
> +	iwe.u.freq.m = bss->freq;
> +	iwe.u.freq.e = 6;
>  	current_ev = iwe_stream_add_event(current_ev, end_buf, &iwe,
>  					  IW_EV_FREQ_LEN);
> -
>  	memset(&iwe, 0, sizeof(iwe));
>  	iwe.cmd = IWEVQUAL;
>  	iwe.u.qual.qual = bss->signal;


      reply	other threads:[~2008-05-23 11:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-22 22:36 [PATCH 1/1] mac80211: reorder channel and freq reporting in wext scan report Tomas Winkler
2008-05-23 11:36 ` Dan Williams [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1211542608.30036.8.camel@localhost.localdomain \
    --to=dcbw@redhat.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=tomas.winkler@intel.com \
    --cc=yi.zhu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox