From: Dan Williams <dcbw@redhat.com>
To: Holger Schurig <hs4233@mail.mn-solutions.de>
Cc: libertas-dev@lists.infradead.org, linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH] libertas: use lbs_pr_XX instead of printk
Date: Fri, 23 May 2008 09:40:25 -0400 [thread overview]
Message-ID: <1211550025.31559.2.camel@localhost.localdomain> (raw)
In-Reply-To: <200805231216.51953.hs4233@mail.mn-solutions.de>
On Fri, 2008-05-23 at 12:16 +0200, Holger Schurig wrote:
> ... because lbs_pr_XXX prefixes all messages with "libertas: "
>
> Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>
Acked-by: Dan Williams <dcbw@redhat.com>
> --- linux.orig/drivers/net/wireless/libertas/cmd.c
> +++ linux/drivers/net/wireless/libertas/cmd.c
> @@ -110,7 +110,7 @@
> * CF card firmware 5.0.16p0: cap 0x00000303
> * USB dongle firmware 5.110.17p2: cap 0x00000303
> */
> - printk("libertas: %s, fw %u.%u.%up%u, cap 0x%08x\n",
> + lbs_pr_info("%s, fw %u.%u.%up%u, cap 0x%08x\n",
> print_mac(mac, cmd.permanentaddr),
> priv->fwrelease >> 24 & 0xff,
> priv->fwrelease >> 16 & 0xff,
> --- linux.orig/drivers/net/wireless/libertas/persistcfg.c
> +++ linux/drivers/net/wireless/libertas/persistcfg.c
> @@ -188,7 +188,7 @@
> return ret;
>
> if (defs.meshie.val.mesh_id_len > IW_ESSID_MAX_SIZE) {
> - printk(KERN_ERR "Inconsistent mesh ID length");
> + lbs_pr_err("inconsistent mesh ID length");
> defs.meshie.val.mesh_id_len = IW_ESSID_MAX_SIZE;
> }
>
prev parent reply other threads:[~2008-05-23 13:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-23 10:16 [PATCH] libertas: use lbs_pr_XX instead of printk Holger Schurig
2008-05-23 13:40 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1211550025.31559.2.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=hs4233@mail.mn-solutions.de \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox