Re: [PATCH 1/1] mac80211: fix deadlock in sta->lock

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 967 bytes --]

On Mon, 2008-05-26 at 17:32 +0300, Tomas Winkler wrote:
> On Mon, May 26, 2008 at 5:19 PM, Johannes Berg
> <johannes@sipsolutions.net> wrote:
> > On Mon, 2008-05-26 at 17:09 +0300, Tomas Winkler wrote:
> >> From: Ron Rindjunsky <ron.rindjunsky@intel.com>
> >>
> >> This patch fixes a deadlock of sta->lock use, occuring while changing
> >> tx aggregation states, as dev_queue_xmit end up in new function
> >> test_and_clear_sta_flags that uses that lock thus leading to deadlock
> >
> > Oh, good catch, thanks. Reminds me to debug the other deadlock I saw
> > (not mac80211 related though)
> >
> very encouraging :) . Can you send me details I also experience some
> lockups on rc2

Well when I resume my machine it locks up right after printing "eth0:
resuming" or something like that, *iff* eth0 was down when suspending. I
fixed a bug like that (NAPI related) a while ago, but w/o sungem changes
it has re-appeared, or so it seems.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]