From: Johannes Berg <johannes@sipsolutions.net>
To: Senthil Balasubramanian <senthilkumar@atheros.com>
Cc: linville@tuxdriver.com, ron.rindjunsky@intel.com,
linux-wireless@vger.kernel.org, Luis.Rodriguez@Atheros.com
Subject: Re: [PATCH] mac80211: fix alignment issue with compare_ether_addr()
Date: Wed, 28 May 2008 17:34:42 +0200 [thread overview]
Message-ID: <1211988882.21624.14.camel@johannes.berg> (raw)
In-Reply-To: <20080528145048.GB5244@senthil-lnx.users.atheros.com>
[-- Attachment #1: Type: text/plain, Size: 358 bytes --]
> + /* Should be aligned on 2 bytes for compare_ether_addr() */
> + u16 src_aligned[ETH_ALEN >> 1];
> + u8 *src = (u8 *)src_aligned;
why not use aligned attribute here as well?
> - static const u8 pae_group_addr[ETH_ALEN]
> + static const u8 pae_group_addr[ETH_ALEN] __attribute__ ((aligned(2)))
I think we should use __aligned(2)
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
prev parent reply other threads:[~2008-05-28 15:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-28 14:50 [PATCH] mac80211: fix alignment issue with compare_ether_addr() Senthil Balasubramanian
2008-05-28 15:16 ` John W. Linville
2008-05-28 16:42 ` Johannes Berg
2008-05-28 16:50 ` Senthilkumar Balasubramanian
2008-05-28 17:07 ` Tomas Winkler
2008-05-28 17:33 ` Senthilkumar Balasubramanian
2008-05-28 18:09 ` Tomas Winkler
2008-05-28 15:34 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1211988882.21624.14.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=Luis.Rodriguez@Atheros.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=ron.rindjunsky@intel.com \
--cc=senthilkumar@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox