Re: question about ...: wrong count at exit"

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 941 bytes --]


> >> However, the function looks quite innocent, and I cannot see
> >> any imbalance there. Did I oversee something or is that a
> >> problem of sparse?
> >
> >>         spin_lock_irq(&priv->driver_lock);
> >>         priv->infra_open = 0;
> >>         netif_stop_queue(dev);
> >>         spin_unlock_irq(&priv->driver_lock);
> >
> > I think it's a sparse problem caused by my patch, I sent further patches
> > to fix it but they were never applied (and had a slight remaining
> > problem too). If you look at the pre-processed function it should become
> > obvious.
> >
> 
> I got plenty of this in the mac80211 reported with newest sparse, but
> they looks false caused by 'goto statements'

Probably similar issues. I have patches that haven't been applied and
with those, mac80211 is clean except for a new warning from netdevice.h,
one that I'll send a patch for in a minute, and the rc-pid algo one.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]