From: Johannes Berg <johannes@sipsolutions.net>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>, Chr <chunkeey@web.de>
Subject: Re: [PATCH] p54: fix skb->cb tx info conversion
Date: Fri, 30 May 2008 21:03:39 +0200 [thread overview]
Message-ID: <1212174219.7238.3.camel@johannes.berg> (raw)
In-Reply-To: <20080530161511.GA24013@tuxdriver.com>
[-- Attachment #1: Type: text/plain, Size: 854 bytes --]
> > + ni = IEEE80211_SKB_CB(entry->next);
> > + freed = ((void *)ni->driver_data)->start_addr
> > + - last_addr;
> > + } else
> > freed = priv->rx_end - last_addr;
> >
> > last_addr = range->end_addr;
>
> CC [M] drivers/net/wireless/p54/p54common.o
> drivers/net/wireless/p54/p54common.c: In function ‘p54_rx_frame_sent’:
> drivers/net/wireless/p54/p54common.c:406: warning: dereferencing ‘void *’ pointer
> drivers/net/wireless/p54/p54common.c:406: error: request for member ‘start_addr’ in something not a structure or union
>
> Looks like you are missing a (struct memrecord *) for the freed
> assignment...?
Umm, yes, this can't work. I wonder what I did, I sure have compiled
this kernel. Must have backed out the patch accidentally. Sorry, will
follow up with a fixed one.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2008-05-30 19:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-26 14:44 [PATCH] p54: fix skb->cb tx info conversion Johannes Berg
2008-05-30 16:15 ` John W. Linville
2008-05-30 19:03 ` Johannes Berg [this message]
2008-05-30 19:07 ` [PATCH v2] " Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1212174219.7238.3.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=chunkeey@web.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).