linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Dan Williams <dcbw@redhat.com>
Cc: linux-wireless@vger.kernel.org, Jouni Malinen <j@w1.fi>
Subject: Re: mac80211 ad-hoc mode problems
Date: Wed, 04 Jun 2008 17:44:12 +0200	[thread overview]
Message-ID: <1212594252.14371.36.camel@johannes.berg> (raw)
In-Reply-To: <1212588799.13676.11.camel@localhost.localdomain>

[-- Attachment #1: Type: text/plain, Size: 2024 bytes --]


> > > 4) Is the association expected to survive a up->down->up sequence?  If
> > > not, then we should be sending NULL SIOCGIWAP event whenever dev_close()
> > > gets called.
> > 
> > No, it's not, yes, we probably should send that event somewhere. Is it
> > ok to send the event while not associated?
> 
> Yeah, there's no ordering or pairing guarantee for SIOCGIWAP events
> since there isn't an association transaction model with WEXT.

Yeah, true. You can either stick it right into ieee80211_stop, make a
new mlme-stop function that is called from there, or maybe do it when
the AP's sta_info struct is removed?

> > > 5) mac80211 requires the device to be down when changing modes.  That's
> > > fine; but requires a patch to wpa_supplicant to handle this.  This would
> > > cause failures when switching AP that were different modes from NM.
> > > See:
> > > 
> > > http://lists.shmoo.com/pipermail/hostap/2008-June/017894.html
> > 
> > Don't understand. How can you switch to an IBSS AP? :)
> 
> Sorry, when switching from BSS -> IBSS, like picking an IBSS from the
> NetworkManager menu while you're connected to an AP.  Or, creating a new
> IBSS while connected.

Ok, but that means you disconnect so you lose all configuration anyway.

> > It's probably fairly easy to remove this restriction because they all
> > use ieee80211_if_sta internally (sta, ibss, mesh) but since I don't care
> > too much about IBSS and see mesh as being quite different, I have no
> > motivation to try (and test) this.
> 
> I think it's fine to leave it as-is.  At least prism54 required the
> interface to be !IFF_UP while changing modes, and I think madwifi has
> required this too at some point.  This can be handled in the supplicant,
> Jouni and I have already worked out what should be done and I'm going to
> update the linked patch.

Sure. As far as I understand, even if mac80211 would change in the
future the patch Jouni asked for would then not down the interface.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

      reply	other threads:[~2008-06-04 15:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-04  1:41 mac80211 ad-hoc mode problems Dan Williams
2008-06-04  9:00 ` Johannes Berg
2008-06-04  9:16   ` Jouni Malinen
2008-06-04 14:18     ` Dan Williams
2008-06-04 15:41       ` Johannes Berg
2008-06-04 15:55       ` Jouni Malinen
2008-06-04 17:30         ` Dan Williams
2008-06-04 14:13   ` Dan Williams
2008-06-04 15:44     ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1212594252.14371.36.camel@johannes.berg \
    --to=johannes@sipsolutions.net \
    --cc=dcbw@redhat.com \
    --cc=j@w1.fi \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).