From: Johannes Berg <johannes@sipsolutions.net>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/7] mac80211: replace ieee80211_get_morefrag with ieee80211_has_morefrags
Date: Mon, 09 Jun 2008 09:38:51 +0200 [thread overview]
Message-ID: <1212997132.698.53.camel@johannes.berg> (raw)
In-Reply-To: <1212774671.6340.76.camel@brick> (sfid-20080606_195947_229598_F1790495)
[-- Attachment #1: Type: text/plain, Size: 324 bytes --]
> - if (ieee80211_get_morefrag(hdr))
> + if (ieee80211_has_morefrags(hdr->frame_control))
looks fine to me, though I wonder if we should have
ieee80211_has_morefrags(struct 80211hdr)
and
__ieee80211_has_morefrags(__le16 fc)
or something with variants of the functions that do the ->frame_control?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2008-06-09 8:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-06 17:51 [PATCH 2/7] mac80211: replace ieee80211_get_morefrag with ieee80211_has_morefrags Harvey Harrison
2008-06-09 7:38 ` Johannes Berg [this message]
2008-06-09 16:29 ` Harvey Harrison
2008-06-09 17:22 ` Johannes Berg
2008-06-09 17:32 ` Harvey Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1212997132.698.53.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=harvey.harrison@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).