Re: [PATCH 1/7] mac80211: add helpers for frame control testing

[Harvey Harrison <harvey.harrison@gmail.com>]

On Mon, 2008-06-09 at 09:37 +0200, Johannes Berg wrote:
> > +static inline u8 *ieee80211_get_qos_ctl(struct ieee80211_hdr *hdr,
> 
> I think this is wrong, the header len will probably at some point
> include more things like HT headers where present or similar, so
> subtracting 2 from the header len is going to be wrong as soon as that
> happens because the QoS control will stay first. I think this should do
> the relevant calculation itself, ie. check for A4.

OK.

> 
> > +static inline int ieee80211_has_protected(__le16 fc)
> 
> > +static inline int ieee80211_has_morefrags(__le16 fc)
> 
> > +static inline int ieee80211_has_tods(__le16 fc)
> 
> > +static inline int ieee80211_has_fromds(__le16 fc)
> 
> > +static inline int ieee80211_has_a4(__le16 fc)
> 
> > +static inline int ieee80211_is_mgmt(__le16 fc)
> 
> > +static inline int ieee80211_is_ctl(__le16 fc)
> 
> > +static inline int ieee80211_is_data(__le16 fc)
> 
> > +static inline int ieee80211_data_has_qos(__le16 fc)
> 
> Can you add kernel-doc comments for these?

OK.

Harvey