From: Harvey Harrison <harvey.harrison@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/7] mac80211: add helpers for frame control testing
Date: Mon, 09 Jun 2008 09:31:26 -0700 [thread overview]
Message-ID: <1213029086.5974.21.camel@brick> (raw)
In-Reply-To: <1212997265.698.55.camel@johannes.berg>
On Mon, 2008-06-09 at 09:41 +0200, Johannes Berg wrote:
> > +static inline int ieee80211_data_has_qos(__le16 fc)
> > +{
> > + /*
> > + * mask with QOS_DATA rather than IEEE80211_FCTL_STYPE as we just need
> > + * to check the one bit
> > + */
> > + return (fc &
> > + cpu_to_le16(IEEE80211_FCTL_FTYPE | IEEE80211_STYPE_QOS_DATA)) ==
> > + cpu_to_le16(IEEE80211_FTYPE_DATA | IEEE80211_STYPE_QOS_DATA);
> > +}
>
> Shouldn't that rather be _is_qos_data?
>
I don't think so....I was trying to keep it so _is_ meant an exact comparison and
_has_ was checking the presence of particular bits.
As this helper only checks for the one bit being set, I chose _has_.
Harvey
next prev parent reply other threads:[~2008-06-09 16:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-06 17:51 [PATCH 1/7] mac80211: add helpers for frame control testing Harvey Harrison
2008-06-09 7:37 ` Johannes Berg
2008-06-09 16:25 ` Harvey Harrison
2008-06-09 7:41 ` Johannes Berg
2008-06-09 16:31 ` Harvey Harrison [this message]
2008-06-09 17:21 ` Johannes Berg
2008-06-09 17:43 ` Harvey Harrison
2008-06-09 17:46 ` Johannes Berg
2008-06-09 17:54 ` Harvey Harrison
2008-06-09 18:02 ` Johannes Berg
2008-06-09 18:22 ` Harvey Harrison
2008-06-09 18:27 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1213029086.5974.21.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).