Re: [PATCH 3/7] mac80211: add utility function to get header length

Tomas Winkler
2008-06-09T10:01:24Z

On Mon, Jun 9, 2008 at 12:16 PM, Johannes Berg
<johannes@sipsolutions.net> wrote:
>
>> /**
>> + * ieee80211_hdrlen - get header length in bytes from frame control
>> + * @fc: frame control field in little-endian format
>> + */
>> +unsigned int ieee80211_hdrlen(__le16 fc);
>> +
>
>> +EXPORT_SYMBOL(ieee80211_hdrlen);
>
> Do we really need to export that?

so now we have hdrlen(u16) and hdrlen(__le16) it will be fun.

So I guess will we converting idioms
u16 fc = le16_to_cpu(hdr->frame_control);
int hdr_len = ieee80211_get_hdrlen(fc);
to
int hdr_len = ieee80211_hdrlen(hdr->frame_control)

This is how it used in driver code so it make sense to export this
function and remove ieee80211_get_hdrlen(fc)

Since all fc operations are bitwise 'and' and 'or'
u16 rx->fc can be dropped in future as well

Tomas