From: Harvey Harrison <harvey.harrison@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCHv2 7/8] mac80211: wme.c use new helpers
Date: Mon, 09 Jun 2008 13:23:46 -0700 [thread overview]
Message-ID: <1213043026.5974.78.camel@brick> (raw)
In-Reply-To: <1213039703.5974.72.camel@brick>
On Mon, 2008-06-09 at 12:28 -0700, Harvey Harrison wrote:
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---
> net/mac80211/wme.c | 18 +++++-------------
> 1 files changed, 5 insertions(+), 13 deletions(-)
>
> diff --git a/net/mac80211/wme.c b/net/mac80211/wme.c
> index 14a9ff1..d8c2f96 100644
> --- a/net/mac80211/wme.c
> +++ b/net/mac80211/wme.c
> @@ -105,11 +105,8 @@ static int classify80211(struct sk_buff *skb, struct Qdisc *qd)
> {
> struct ieee80211_local *local = wdev_priv(qd->dev->ieee80211_ptr);
> struct ieee80211_hdr *hdr = (struct ieee80211_hdr *) skb->data;
> - unsigned short fc = le16_to_cpu(hdr->frame_control);
> - int qos;
>
> - /* see if frame is data or non data frame */
> - if (unlikely((fc & IEEE80211_FCTL_FTYPE) != IEEE80211_FTYPE_DATA)) {
> + if (!ieee80211_is_data(hdr->frame_control)) {
Sorry, I didn't refresh this patch to preserve the unlikely().
Let me know if you want a replacement.
Harvey
prev parent reply other threads:[~2008-06-09 20:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-09 19:28 [PATCHv2 7/8] mac80211: wme.c use new helpers Harvey Harrison
2008-06-09 20:23 ` Harvey Harrison [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1213043026.5974.78.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox