From: Johannes Berg <johannes@sipsolutions.net>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Tomas Winkler <tomasw@gmail.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [RFC-PATCH] mac80211: eliminate cached fc from struct ieee80211_{tx|rx}_data
Date: Tue, 10 Jun 2008 10:07:01 +0200 [thread overview]
Message-ID: <1213085221.22220.32.camel@johannes.berg> (raw)
In-Reply-To: <1213057737.5974.118.camel@brick> (sfid-20080610_022903_151933_8E439F92)
[-- Attachment #1: Type: text/plain, Size: 763 bytes --]
On Mon, 2008-06-09 at 17:28 -0700, Harvey Harrison wrote:
> Rather than keep a cached host-endian frame control, use byteswapped
> helpers throughout and get the frame control directly from the 802.11
> frame itself.
>
> Very little testing has been done so far of this, but it does compile.
>
> Applies on top of the 8-patch series adding byteswapped frame control
> helpers.
Cool. I'll test it later.
> - case (IEEE80211_FCTL_TODS | IEEE80211_FCTL_FROMDS):
> + if (ieee80211_has_a4(fc)) {
I wonder if the compiler was smart enough to make the switch statement
into something like
if (fromds) {
if (tods) {
...
} else {
...
}
} else {
if (tods) {
...
} else {
...
}
}
and if we should do that?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2008-06-10 8:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-10 0:28 [RFC-PATCH] mac80211: eliminate cached fc from struct ieee80211_{tx|rx}_data Harvey Harrison
2008-06-10 8:07 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1213085221.22220.32.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=harvey.harrison@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=tomasw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox