Re: [RFC PATCH 2/2] mac80211: workaround for resetting the tx power

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 1574 bytes --]

On Thu, 2008-06-19 at 21:35 +0300, Tomas Winkler wrote:
> From: Assaf Krauss <assaf.krauss@intel.com>
> 
> This patch is a workaround for the unreliable disassociation
> flow. The resetting of the tx power is now performed upon
> association/reassociation.
> 
> Signed-off-by: Assaf Krauss <assaf.krauss@intel.com>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> ---
>  net/mac80211/mlme.c |   13 +++++++++++++
>  1 files changed, 13 insertions(+), 0 deletions(-)
> 
> diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
> index 313b02a..378ccd5 100644
> --- a/net/mac80211/mlme.c
> +++ b/net/mac80211/mlme.c
> @@ -2148,6 +2148,19 @@ static void ieee80211_rx_mgmt_assoc_resp(struct ieee80211_sub_if_data *sdata,
>  	/* AssocResp and ReassocResp have identical structure, so process both
>  	 * of them in this function. */
>  
> +	/***********************************************************
> +	 * Workaround - Until disassociation flow is trustworthy...
> +	 ***********************************************************/
> +	/* Reset power level. Get the tx power from the current channel/user.*/
> +	if (ifsta->country_max_pwr || local->hw.conf.tpc_pwr_limit) {
> +		ifsta->country_max_pwr = 0;
> +		local->hw.conf.tpc_pwr_limit = 0;
> +		ieee80211_hw_config(local);
> +	}
> +	/***********************************************************
> +	 * End of Workaround
> +	 ***********************************************************/

Umm, can you explain/fix the problem instead of adding ugly comments
like that?

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]