Re: [PATCH] mac80211: Add RTNL warning for workqueue

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 1105 bytes --]

On Tue, 2008-06-24 at 19:28 +0200, Johannes Berg wrote:
> On Tue, 2008-06-24 at 19:23 +0200, Ivo van Doorn wrote:
> > The workqueue provided by mac80211 should not be used for
> > scheduled tasks that acquire the RTNL lock. This could be done
> > when the driver uses the function ieee80211_iterate_active_interfaces()
> > within the scheduled work. Such behavior will end in locking
> > dependencies problems when an interface is being removed.
> > 
> > This patch will add a notification about the RTNL locking and
> > the mac80211 workqueue to prevent driver developers from
> > blindly using it.
> > 
> > Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
> > Cc: Johannes Berg <johannes@sipsolutions.net>

> Interesting point. Should it be there or rather be moved down a bit so
> that it is actually only flushed when _all_ interfaces are stopped, i.e.
> before ->stop is invoked?

Either way though, the patch is obviously correct and a follow-up patch
can change the behaviour if we want that, so for this one:

Acked-by: Johannes Berg <johannes@sipsolutions.net>

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]