From: Pavel Roskin <proski@gnu.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linville@tuxdriver.com, hintak_leung@yahoo.co.uk,
linux-wireless@vger.kernel.org
Subject: Re: [RFC] rtl8187: Realtek 8187B wireless support with product id0x8197/0x8189
Date: Wed, 25 Jun 2008 13:57:42 -0400 [thread overview]
Message-ID: <1214416662.9237.6.camel@dv> (raw)
In-Reply-To: <4862840F.4030409@lwfinger.net>
On Wed, 2008-06-25 at 12:44 -0500, Larry Finger wrote:
> I realize that now. I'll fix that. Is it OK that there is a
> "Signed-off-by" for you?
As far as the copyright goes, yes. But I was mostly forward porting and
removing unrelated parts, so there is very little code written by me in
that patch.
I'm not sure I can stand behind that patch quality-wise. It's 40k of
intrusive changes that I could not even test on an old rtl8187. If I
had more time and a original rtl8187 device, I would try to split more
parts or restructure the code first.
Also, the startup time (ifconfig up) is over 20 seconds, which is
absolutely unacceptable. Either some delays are over-conservative, or
we are doing something wrong.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2008-06-25 17:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-25 16:59 [RFC] rtl8187: Realtek 8187B wireless support with product id0x8197/0x8189 Larry.Finger
2008-06-25 17:07 ` Johannes Berg
2008-06-25 17:21 ` Pavel Roskin
2008-06-25 17:36 ` Pavel Roskin
2008-06-25 17:44 ` Larry Finger
2008-06-25 17:57 ` Pavel Roskin [this message]
2008-06-25 18:25 ` Larry Finger
2008-06-25 20:12 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1214416662.9237.6.camel@dv \
--to=proski@gnu.org \
--cc=Larry.Finger@lwfinger.net \
--cc=hintak_leung@yahoo.co.uk \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).