From: Johannes Berg <johannes@sipsolutions.net>
To: Ivo Van Doorn <ivdoorn@gmail.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org,
rt2400-devel@lists.sourceforge.net
Subject: Re: [PATCH] rt2x00: Fix lock dependency errror
Date: Wed, 25 Jun 2008 22:20:39 +0200 [thread overview]
Message-ID: <1214425240.21847.57.camel@johannes.berg> (raw)
In-Reply-To: <a32f33a40806251318n4f0bac2cs7ada6e23afe0cb6e@mail.gmail.com> (sfid-20080625_221835_923416_D8569C55)
[-- Attachment #1: Type: text/plain, Size: 783 bytes --]
On Wed, 2008-06-25 at 22:18 +0200, Ivo Van Doorn wrote:
> >> diff --git a/drivers/net/wireless/rt2x00/rt2x00.h b/drivers/net/wireless/rt2x00/rt2x00.h
> >> index 611d983..73dacbb 100644
> >> --- a/drivers/net/wireless/rt2x00/rt2x00.h
> >> +++ b/drivers/net/wireless/rt2x00/rt2x00.h
> >> @@ -821,6 +822,7 @@ struct rt2x00_dev {
> >> /*
> >> * Scheduled work.
> >> */
> >> + struct workqueue_struct *workqueue;
> >
> > Do you really need a whole workqueue (kernel thread) per device? I would
> > think that using schedule_work / cancel_work_sync for this task and keep
> > using the mac80211 wq would be sufficient?
>
> True, but this is a quick patch to resolve the bug for sure.
Fair enough, this is a fix for 2.6.26 after all.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2008-06-25 20:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-25 19:27 [PATCH] rt2x00: Fix lock dependency errror Ivo van Doorn
2008-06-25 19:33 ` Johannes Berg
2008-06-25 20:18 ` Ivo Van Doorn
2008-06-25 20:20 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1214425240.21847.57.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=ivdoorn@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rt2400-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox