From: Johannes Berg <johannes@sipsolutions.net>
To: Tomas Winkler <tomas.winkler@intel.com>
Cc: linville@tuxdriver.com, yi.zhu@intel.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/1] mac80211: fix warning: unused variable invoke_tx_handlers
Date: Sat, 28 Jun 2008 09:58:20 +0200 [thread overview]
Message-ID: <1214639900.5507.8.camel@johannes.berg> (raw)
In-Reply-To: <1214612103-8389-1-git-send-email-tomas.winkler@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1567 bytes --]
On Sat, 2008-06-28 at 03:15 +0300, Tomas Winkler wrote:
> This patch fixes warning: unused variable in invoke_tx_handlers
> when compiling without MAC80211_DEBUG option
Guess I haven't compiled like that in a long time.
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Acked-by: Johannes Berg <johannes@sipsolutions.net>
> ---
> net/mac80211/tx.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
> index 345d6ff..a8c1809 100644
> --- a/net/mac80211/tx.c
> +++ b/net/mac80211/tx.c
> @@ -1110,7 +1110,6 @@ static int __ieee80211_tx(struct ieee80211_local *local, struct sk_buff *skb,
> */
> static int invoke_tx_handlers(struct ieee80211_tx_data *tx)
> {
> - struct ieee80211_local *local = tx->local;
> struct sk_buff *skb = tx->skb;
> ieee80211_tx_handler *handler;
> ieee80211_tx_result res = TX_DROP;
> @@ -1123,7 +1122,7 @@ static int invoke_tx_handlers(struct ieee80211_tx_data *tx)
> }
>
> if (unlikely(res == TX_DROP)) {
> - I802_DEBUG_INC(local->tx_handlers_drop);
> + I802_DEBUG_INC(tx->local->tx_handlers_drop);
> dev_kfree_skb(skb);
> for (i = 0; i < tx->num_extra_frag; i++)
> if (tx->extra_frag[i])
> @@ -1131,7 +1130,7 @@ static int invoke_tx_handlers(struct ieee80211_tx_data *tx)
> kfree(tx->extra_frag);
> return -1;
> } else if (unlikely(res == TX_QUEUED)) {
> - I802_DEBUG_INC(local->tx_handlers_queued);
> + I802_DEBUG_INC(tx->local->tx_handlers_queued);
> return -1;
> }
>
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2008-06-28 7:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-28 0:15 [PATCH 1/1] mac80211: fix warning: unused variable invoke_tx_handlers Tomas Winkler
2008-06-28 7:58 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1214639900.5507.8.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=tomas.winkler@intel.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox