From: Felipe Maya <felipe.maya@vexcorp.com>
To: Michael Buesch <mb@bu3sch.de>
Cc: linux-wireless@vger.kernel.org, bcm43xx-dev@lists.berlios.de
Subject: Re: [PATCH] ssb, b43, b43legacy, b44: Rewrite SSB DMA API
Date: Thu, 03 Jul 2008 12:30:18 -0400 [thread overview]
Message-ID: <1215102618.17143.13.camel@you> (raw)
In-Reply-To: <200806201150.29497.mb@bu3sch.de>
Hi, I have applied this patch and i tested on a wl500gpv2 (BCM5354). The
following part disable the ethernet device. If this part of the patch is
restored the device work ok.
>
> -int ssb_dma_set_mask(struct ssb_device *ssb_dev, u64 mask)
> +int ssb_dma_set_mask(struct ssb_device *dev, u64 mask)
> {
> - struct device *dma_dev = ssb_dev->dma_dev;
> - int err = 0;
> + int err;
>
> -#ifdef CONFIG_SSB_PCIHOST
> - if (ssb_dev->bus->bustype == SSB_BUSTYPE_PCI) {
> - err = pci_set_dma_mask(ssb_dev->bus->host_pci, mask);
> + switch (dev->bus->bustype) {
> + case SSB_BUSTYPE_PCI:
> + err = pci_set_dma_mask(dev->bus->host_pci, mask);
> if (err)
> return err;
> - err = pci_set_consistent_dma_mask(ssb_dev->bus->host_pci, mask);
> + err = pci_set_consistent_dma_mask(dev->bus->host_pci, mask);
> return err;
> + case SSB_BUSTYPE_SSB:
> + return dma_set_mask(dev->dev, mask);
> + default:
> + __ssb_dma_not_implemented(dev);
> }
> -#endif
> - dma_dev->coherent_dma_mask = mask;
> - dma_dev->dma_mask = &dma_dev->coherent_dma_mask;
> -
> - return err;
> + return -ENOSYS;
> }
> EXPORT_SYMBOL(ssb_dma_set_mask);
next prev parent reply other threads:[~2008-07-03 15:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-20 9:50 [PATCH] ssb, b43, b43legacy, b44: Rewrite SSB DMA API Michael Buesch
2008-06-20 10:41 ` Michael Buesch
2008-06-21 0:05 ` Larry Finger
2008-06-21 9:30 ` Michael Buesch
2008-07-03 16:30 ` Felipe Maya [this message]
2008-07-03 20:52 ` Michael Buesch
2008-07-03 21:07 ` Michael Buesch
2008-07-08 15:58 ` Steve Brown
2008-07-08 17:04 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1215102618.17143.13.camel@you \
--to=felipe.maya@vexcorp.com \
--cc=bcm43xx-dev@lists.berlios.de \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).