From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from xc.sipsolutions.net ([83.246.72.84]:46638 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752573AbYGHLuS (ORCPT ); Tue, 8 Jul 2008 07:50:18 -0400 Subject: [PATCH] CONFIG_KMOD needs to be default y From: Johannes Berg To: Andrew Morton Cc: linux-wireless , Linux Kernel list , Herbert Xu , Tomas Winkler , rusty Content-Type: text/plain Date: Tue, 08 Jul 2008 13:49:31 +0200 Message-Id: <1215517771.9610.28.camel@johannes.berg> (sfid-20080708_135022_995408_23725060) Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: Far too many people configure their kernel without CONFIG_KMOD and then complain that wireless breaks, thanks to Herbert Xu for pointing me to this. This patch makes CONFIG_KMOD default to "y" and adds a warning that people should not turn it off. Signed-off-by: Johannes Berg Cc: Herbert Xu Cc: Rusty Russell --- Maybe it should even depend on EMBEDDED? Who needs this option off in the first place? init/Kconfig | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) --- everything.orig/init/Kconfig 2008-07-08 13:42:10.000000000 +0200 +++ everything/init/Kconfig 2008-07-08 13:43:41.000000000 +0200 @@ -895,6 +895,7 @@ config MODULE_SRCVERSION_ALL config KMOD bool "Automatic kernel module loading" depends on MODULES + default y help Normally when you have selected some parts of the kernel to be created as kernel modules, you must load them (using the @@ -902,7 +903,12 @@ config KMOD here, some parts of the kernel will be able to load modules automatically: when a part of the kernel needs a module, it runs modprobe with the appropriate arguments, thereby - loading the module if it is available. If unsure, say Y. + loading the module if it is available. + + Do not say N unless you know you do not need it, and expect + wireless, crypto and other things to break in this case. + + Say Y. config STOP_MACHINE bool