From: Harvey Harrison <harvey.harrison@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: John Linville <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/3] mac80211: use ieee80211 frame control directly
Date: Wed, 09 Jul 2008 08:49:31 -0700 [thread overview]
Message-ID: <1215618572.476.70.camel@brick> (raw)
In-Reply-To: <1215589460.3670.30.camel@johannes.berg>
On Wed, 2008-07-09 at 09:44 +0200, Johannes Berg wrote:
> > --- a/net/mac80211/wep.c
> > +++ b/net/mac80211/wep.c
> > @@ -291,9 +291,10 @@ u8 * ieee80211_wep_is_weak_iv(struct sk_buff *skb, struct ieee80211_key *key)
> > ieee80211_rx_result
> > ieee80211_crypto_wep_decrypt(struct ieee80211_rx_data *rx)
> > {
> > - if ((rx->fc & IEEE80211_FCTL_FTYPE) != IEEE80211_FTYPE_DATA &&
> > - ((rx->fc & IEEE80211_FCTL_FTYPE) != IEEE80211_FTYPE_MGMT ||
> > - (rx->fc & IEEE80211_FCTL_STYPE) != IEEE80211_STYPE_AUTH))
> > + struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)rx->skb->data;
> > +
> > + if (ieee80211_is_data(hdr->frame_control) &&
> > + ieee80211_is_auth(hdr->frame_control))
> > return RX_CONTINUE;
>
> That one seems impossible to hit now and should be !is_data && !is_auth
> I think.
Yep. I'll have another look over this to see if I made any others.
Harvey
next prev parent reply other threads:[~2008-07-09 15:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-09 2:00 [PATCH 2/3] mac80211: use ieee80211 frame control directly Harvey Harrison
2008-07-09 7:44 ` Johannes Berg
2008-07-09 15:49 ` Harvey Harrison [this message]
2008-07-09 15:50 ` Johannes Berg
2008-07-09 17:00 ` Harvey Harrison
2008-07-09 17:35 ` [PATCHv2 " Harvey Harrison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1215618572.476.70.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).