From: Johannes Berg <johannes@sipsolutions.net>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: TXQ real_num_tx_queues comments/questions
Date: Tue, 15 Jul 2008 11:49:09 +0200 [thread overview]
Message-ID: <1216115349.3535.20.camel@johannes.berg> (raw)
In-Reply-To: <20080715.023954.234208581.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 641 bytes --]
On Tue, 2008-07-15 at 02:39 -0700, David Miller wrote:
> From: Johannes Berg <johannes@sipsolutions.net>
> Date: Tue, 15 Jul 2008 11:37:01 +0200
>
> > From mac80211's POV it's just that select_queue must have known
> > about the removed queue when the requeue is done. And we can defer
> > the requeue to a workqueue.
>
> Ok.
>
> So you're proposing the requeue be deferred to a workqueue
> and what else? RCU protection around real_num_tx_queues
> access?
Yes, I think we can fix it by deferring the requeue to a workqueue,
using synchronize_net() and putting RCU protection against the
select_queue call.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2008-07-15 9:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-11 9:47 TXQ real_num_tx_queues comments/questions Johannes Berg
2008-07-15 9:16 ` David Miller
2008-07-15 9:25 ` Johannes Berg
2008-07-15 9:28 ` David Miller
2008-07-15 9:37 ` Johannes Berg
2008-07-15 9:39 ` David Miller
2008-07-15 9:49 ` Johannes Berg [this message]
2008-07-15 10:05 ` David Miller
2008-07-15 10:28 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1216115349.3535.20.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox