Re: Commit 741b4fbc44 (mac80211: fix TX sequence numbers) breaks rtl8187

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 1487 bytes --]

On Wed, 2008-07-23 at 00:43 -0500, Larry Finger wrote:
> Johannes,
> 
> In the current wireless-testing (v2.6.26-rc9-14207-ga520bdb), rtl8187 is broken. 
> In most cases, it is unable to complete a connection. Occasionally, it will 
> authenticate and even get an IP using DHCP; however, only a few pings get 
> through to the AP before the connection fails completely.
> 
> Using bisection, this problem was traced to:
> 
> ==================================================
> commit 741b4fbc441dba885cc8f97a10e87f2acd04c5f2
> Author: Johannes Berg <johannes@sipsolutions.net>
> Date:   Thu Jul 10 11:21:26 2008 +0200
> 
>      mac80211: fix TX sequence numbers

> The validity of the bisection was confirmed by reverse application of the patch. 
> The resulting driver worked.
> 
> The appears that rtl8187 needs some kind of modification such as b43, b43legacy, 
> and rt2x00 got in the original patch. I'll be studying the changes to the other 
> drivers to see if I can find the problem, but I will appreciate your help when 
> you get a chance. Perhaps after your trip to Canada is over.

Oh, crap. If you look at the patch, it removes the sequence numbers for
non-TID frames, and puts them back into rt2x00 because I thought rt2x00
was the only driver that needed software sequence numbering. It looks
like rtl8187 and zd1211 might need that too, so we need to copy the
rt2x00 code that I put into that particular patch to those drivers.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]