From: Pavel Roskin <proski@gnu.org>
To: Nick Kossifidis <mick@madwifi.org>
Cc: ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org,
linville@tuxdriver.com, jirislaby@gmail.com, mcgrof@gmail.com
Subject: Re: [PATCH 1/12] ath5k: Update register list
Date: Thu, 24 Jul 2008 17:23:25 -0400 [thread overview]
Message-ID: <1216934605.3094.5.camel@dv> (raw)
In-Reply-To: <20080720033041.GA7440@makis>
On Sun, 2008-07-20 at 06:30 +0300, Nick Kossifidis wrote:
> * Update list of registers
> * Use updated register macros inside hw.c and initvals.c
What happened to those patches? Are they going to be applied? Maybe
more cleanup is needed?
> - ath5k_hw_reg_write(ah, 0x0002a002, AR5K_PHY(11));
> + ath5k_hw_reg_write(ah, 0x0002a002, 0x982c);
You are replacing macros with numbers in several places. Maybe you
could introduce another macro? Or is it the case when you had
interpretation of the registers, but now realize that it was wrong?
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2008-07-24 21:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-20 3:30 [PATCH 1/12] ath5k: Update register list Nick Kossifidis
2008-07-24 21:23 ` Pavel Roskin [this message]
2008-07-24 21:35 ` Nick Kossifidis
2008-07-24 21:55 ` [ath5k-devel] " Bob Copeland
2008-07-25 19:45 ` Nick Kossifidis
2008-07-29 20:40 ` John W. Linville
2008-07-30 9:47 ` [ath5k-devel] " Nick Kossifidis
2008-07-31 18:51 ` Nick Kossifidis
2008-08-02 19:33 ` Nick Kossifidis
2008-07-30 10:18 ` Nick Kossifidis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1216934605.3094.5.camel@dv \
--to=proski@gnu.org \
--cc=ath5k-devel@lists.ath5k.org \
--cc=jirislaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@gmail.com \
--cc=mick@madwifi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).