From: Luis Carlos Cobo <luisca@cozybit.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] mac80211: partially fix skb->cb use
Date: Tue, 29 Jul 2008 14:03:40 +0200 [thread overview]
Message-ID: <1217333020.6379.31.camel@localhost> (raw)
In-Reply-To: <1217332288.10489.33.camel@johannes.berg>
On Tue, 2008-07-29 at 13:51 +0200, Johannes Berg wrote:
> That sounds sane to me, then you don't need the cb at all, do you? Can
> just send it to the master dev with skb->do_not_encrypt set, right?
Right.
> In fact, looking at the code, there seems to be a bug with promisc, are
> you sure it's allowed to netif_rx/dev_queue_xmit the same frame?
I see, not doing a copy on that case. Yeah, that needs to be fixed, I'll
take care of it.
--
Luis Carlos Cobo Rus GnuPG ID: 44019B60
cozybit Inc.
next prev parent reply other threads:[~2008-07-29 12:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-29 9:32 [PATCH] mac80211: partially fix skb->cb use Johannes Berg
2008-07-29 10:13 ` David Miller
2008-07-29 10:48 ` Tomas Winkler
2008-07-29 10:49 ` Johannes Berg
2008-07-29 11:01 ` Tomas Winkler
2008-07-29 11:23 ` Luis Carlos Cobo
2008-07-29 11:24 ` Johannes Berg
2008-07-29 11:42 ` Luis Carlos Cobo
2008-07-29 11:51 ` Johannes Berg
2008-07-29 12:03 ` Luis Carlos Cobo [this message]
2008-07-29 12:07 ` Johannes Berg
2008-07-29 15:58 ` Luis Carlos Cobo
2008-07-30 7:17 ` Johannes Berg
2008-07-29 14:47 ` Larry Finger
2008-07-29 14:50 ` Johannes Berg
2008-07-29 20:49 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1217333020.6379.31.camel@localhost \
--to=luisca@cozybit.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox