From: Pavel Roskin <proski@gnu.org>
To: lrodriguez@atheros.com
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
ath9k-devel@lists.ath9k.org, Jouni.Malinen@Atheros.com,
Vasanthakumar Thiagarajan <vasanth@atheros.com>
Subject: Re: [PATCH 06/16] ath9k: Fix missing brace in branch on ath_chainmask_sel_logic()
Date: Wed, 30 Jul 2008 21:11:47 -0400 [thread overview]
Message-ID: <1217466707.3616.5.camel@dv> (raw)
In-Reply-To: <40a067eab54b9b366002257d5be8e4577b067408.1217309551.git.lrodriguez@atheros.com>
On Mon, 2008-07-28 at 22:47 -0700, lrodriguez@atheros.com wrote:
> From: Vasanthakumar Thiagarajan <vasanth@atheros.com>
>
> diff --git a/drivers/net/wireless/ath9k/core.c b/drivers/net/wireless/ath9k/core.c
> index 47d4891..d9c7561 100644
> --- a/drivers/net/wireless/ath9k/core.c
> +++ b/drivers/net/wireless/ath9k/core.c
> @@ -508,9 +508,10 @@ int ath_chainmask_sel_logic(struct ath_softc *sc, struct ath_node *an)
> * enabled/disabled setting
> */
> if ((sc->sc_no_tx_3_chains == AH_FALSE) ||
> - (sc->sc_config.chainmask_sel == AH_FALSE))
> + (sc->sc_config.chainmask_sel == AH_FALSE)) {
> cm->cur_tx_mask = sc->sc_tx_chainmask;
> return cm->cur_tx_mask;
> + }
I would prefer that all compile fixes are amended in the patches that
introduced them. We should try to pass only correct patches upstream.
Bisection works best if one doesn't hit code that doesn't compile.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2008-07-31 1:11 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-29 5:47 [PATCH 00/16] ath9k: some cleanups, and a few small fixes lrodriguez
2008-07-29 5:47 ` [PATCH 02/16] ath9k: Remove ineffective multirate retry stuff lrodriguez
2008-07-29 5:47 ` [PATCH 03/16] ath9k: Clean up in antenna diversity handling. Get rid of sc_needmib lrodriguez
2008-07-29 5:47 ` [PATCH 04/16] ath9k: Use struct ath_softc directly instead of a void pointer lrodriguez
2008-07-29 5:47 ` [PATCH 05/16] ath9k: Use 'ATH9K' as a prefix instead of 'HAL' for a lot of macros lrodriguez
2008-07-29 5:47 ` [PATCH 06/16] ath9k: Fix missing brace in branch on ath_chainmask_sel_logic() lrodriguez
2008-07-31 1:11 ` Pavel Roskin [this message]
2008-07-31 1:21 ` Luis R. Rodriguez
2008-07-31 1:41 ` Pavel Roskin
2008-07-29 5:47 ` [PATCH 07/16] ath9k: Replace enum hal_bool with bool lrodriguez
2008-07-29 5:47 ` [PATCH 08/16] ath9k: Revamp debugging lrodriguez
2008-07-29 5:47 ` [PATCH 09/16] ath9k: Use standard ISR return values, merge ath_intr and ath_isr lrodriguez
2008-07-29 5:47 ` [PATCH 10/16] ath9k: Don't pass opmode twice to ath_vap_attach, return standard error values from add_interface lrodriguez
2008-07-29 5:47 ` [PATCH 11/16] ath9k: Remove "OS_" prefixes in macros lrodriguez
2008-07-31 1:16 ` Pavel Roskin
2008-07-31 1:23 ` Luis R. Rodriguez
2008-07-31 1:44 ` Pavel Roskin
2008-07-31 2:06 ` Luis R. Rodriguez
2008-07-29 5:47 ` [PATCH 12/16] ath9k: Dont maintain some of h/w caps in ath_softc, access them directly from ah_caps instead lrodriguez
2008-07-29 5:47 ` [PATCH 13/16] ath9k: Break down ath9k_regd_init_channels and use helper functions lrodriguez
2008-07-29 5:47 ` [PATCH 14/16] ath9k: Remove AH_DEBUG_COUNTRY lrodriguez
2008-07-29 5:47 ` [PATCH 15/16] ath9k: Don't set the channel in ath_rate_init() lrodriguez
2008-07-29 5:47 ` [PATCH 16/16] ath9k: Remove some unused macros lrodriguez
2008-07-29 5:50 ` [PATCH 00/16] ath9k: some cleanups, and a few small fixes Luis R. Rodriguez
2008-07-29 5:52 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1217466707.3616.5.camel@dv \
--to=proski@gnu.org \
--cc=Jouni.Malinen@Atheros.com \
--cc=ath9k-devel@lists.ath9k.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
--cc=vasanth@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).