linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kilroyd@googlemail.com
To: linux-wireless@vger.kernel.org
Cc: proski@gnu.org, orinoco-devel@lists.sourceforge.net,
	David Kilroy <kilroyd@gmail.com>
Subject: [PATCH 03/19] orinoco: Specify all three parameters to every Hermes command.
Date: Sat,  2 Aug 2008 11:14:17 +0100	[thread overview]
Message-ID: <1217672073-7094-4-git-send-email-kilroyd@gmail.com> (raw)
In-Reply-To: <1217672073-7094-3-git-send-email-kilroyd@gmail.com>

hermes_issue_cmd now takes two more parameters.

Signed-off-by: David Kilroy <kilroyd@gmail.com>
---
 drivers/net/wireless/hermes.c |   13 +++++++------
 1 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/drivers/net/wireless/hermes.c b/drivers/net/wireless/hermes.c
index 29d3910..5504155 100644
--- a/drivers/net/wireless/hermes.c
+++ b/drivers/net/wireless/hermes.c
@@ -87,7 +87,8 @@ MODULE_LICENSE("Dual MPL/GPL");
 
    Callable from any context.
 */
-static int hermes_issue_cmd(hermes_t *hw, u16 cmd, u16 param0)
+static int hermes_issue_cmd(hermes_t *hw, u16 cmd, u16 param0,
+			    u16 param1, u16 param2)
 {
 	int k = CMD_BUSY_TIMEOUT;
 	u16 reg;
@@ -103,8 +104,8 @@ static int hermes_issue_cmd(hermes_t *hw, u16 cmd, u16 param0)
 		return -EBUSY;
 	}
 
-	hermes_write_regn(hw, PARAM2, 0);
-	hermes_write_regn(hw, PARAM1, 0);
+	hermes_write_regn(hw, PARAM2, param2);
+	hermes_write_regn(hw, PARAM1, param1);
 	hermes_write_regn(hw, PARAM0, param0);
 	hermes_write_regn(hw, CMD, cmd);
 	
@@ -162,7 +163,7 @@ int hermes_init(hermes_t *hw)
 
 	/* We don't use hermes_docmd_wait here, because the reset wipes
 	   the magic constant in SWSUPPORT0 away, and it gets confused */
-	err = hermes_issue_cmd(hw, HERMES_CMD_INIT, 0);
+	err = hermes_issue_cmd(hw, HERMES_CMD_INIT, 0, 0, 0);
 	if (err)
 		return err;
 
@@ -216,7 +217,7 @@ int hermes_docmd_wait(hermes_t *hw, u16 cmd, u16 parm0,
 	u16 reg;
 	u16 status;
 
-	err = hermes_issue_cmd(hw, cmd, parm0);
+	err = hermes_issue_cmd(hw, cmd, parm0, 0, 0);
 	if (err) {
 		if (! hermes_present(hw)) {
 			if (net_ratelimit())
@@ -497,7 +498,7 @@ int hermes_write_ltv(hermes_t *hw, int bap, u16 rid,
 
 	hermes_write_bytes(hw, dreg, value, count << 1);
 
-	err = hermes_docmd_wait(hw, HERMES_CMD_ACCESS | HERMES_CMD_WRITE, 
+	err = hermes_docmd_wait(hw, HERMES_CMD_ACCESS | HERMES_CMD_WRITE,
 				rid, NULL);
 
 	return err;
-- 
1.5.4.5


  reply	other threads:[~2008-08-02 10:15 UTC|newest]

Thread overview: 75+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-02 10:14 [PATCH 00/19] orinoco: WPA for Agere based cards kilroyd
2008-08-02 10:14 ` [PATCH 01/19] orinoco: Add ESSID specific scanning for Agere fw kilroyd
2008-08-02 10:14   ` [PATCH 02/19] orinoco: Update scan translation kilroyd
2008-08-02 10:14     ` kilroyd [this message]
2008-08-02 10:14       ` [PATCH 04/19] orinoco: Move EXPORT_SYMBOL declarations next to exported function kilroyd
2008-08-02 10:14         ` [PATCH 05/19] orinoco: Add function to execute Hermes initialisation commands synchronously kilroyd
2008-08-02 10:14           ` [PATCH 06/19] orinoco: Move firmware download functionality into new module kilroyd
2008-08-02 10:14             ` [PATCH 07/19] orinoco: Make firmware download logic more generic kilroyd
2008-08-02 10:14               ` [PATCH 08/19] orinoco: Extend hermes_dld routines for Agere firmware kilroyd
2008-08-02 10:14                 ` [PATCH 09/19] orinoco: Invoke firmware download in main driver kilroyd
2008-08-02 10:14                   ` [PATCH 10/19] orinoco: Fix transmit for Agere/Lucent with fw 9.x kilroyd
2008-08-02 10:14                     ` [PATCH 11/19] orinoco: address checkpatch typedef warning kilroyd
2008-08-02 10:14                       ` [PATCH 12/19] orinoco: Use extended Agere scans available on 9.x series firmwares kilroyd
2008-08-02 10:14                         ` [PATCH 13/19] orinoco: Don't use boolean parameter to record encoding type kilroyd
2008-08-02 10:14                           ` [PATCH 14/19] orinoco: Split wevent work thread from wevent sending kilroyd
2008-08-02 10:14                             ` [PATCH 15/19] orinoco: Use a macro to define wireless handlers kilroyd
2008-08-02 10:14                               ` [PATCH 16/19] orinoco: Add WE-18 ioctls for WPA kilroyd
2008-08-02 10:14                                 ` [PATCH 17/19] orinoco: Send association events to userspace kilroyd
2008-08-02 10:14                                   ` [PATCH 18/19] orinoco: Process bulk of receive interrupt in a tasklet kilroyd
2008-08-02 10:14                                     ` [PATCH 19/19] orinoco: Add MIC on TX and check on RX kilroyd
2008-08-02 10:22                               ` [PATCH 15/19] orinoco: Use a macro to define wireless handlers kilroyd
2008-08-04  4:48   ` [PATCH 01/19] orinoco: Add ESSID specific scanning for Agere fw Pavel Roskin
2008-08-04 15:34     ` Dan Williams
2008-08-05 16:22       ` Jean Tourrilhes
2008-09-02 23:06         ` Jean Tourrilhes
2008-09-08 12:48           ` Pavel Roskin
2008-09-08 16:45             ` Jean Tourrilhes
2008-09-08 18:32             ` Jean Tourrilhes
2008-09-09 18:37               ` Dave
2008-09-09 19:33                 ` Jean Tourrilhes
2008-09-09 21:20                   ` Tomas Winkler
2008-09-09 21:44                     ` Jean Tourrilhes
2008-09-13  4:17               ` Pavel Roskin
2008-09-15 21:17                 ` Jean Tourrilhes
2008-08-05 21:15       ` Pavel Roskin
2008-08-05 21:50         ` Dave
2008-08-05 21:55         ` Dan Williams
2008-08-05 22:48           ` Pavel Roskin
2008-08-06 13:13             ` Dan Williams
2008-08-06 13:48               ` Pavel Roskin
2008-08-06 19:26                 ` Dave
2008-08-06 19:29               ` Dave
2008-08-06 20:56                 ` Dan Williams
2008-08-06 21:03                   ` Dan Williams
2008-08-06 21:08                   ` Dave
2008-08-07  2:48                     ` Dan Williams
2008-08-07 18:43                       ` Dave
2008-08-07 19:42                         ` Dan Williams
2008-08-07 20:17                           ` Dave
2008-08-07 20:46                             ` Dan Williams
2008-08-07 21:08                           ` Dave
2008-08-08 14:51                             ` Dan Williams
2008-08-04  3:57 ` [PATCH 00/19] orinoco: WPA for Agere based cards Pavel Roskin
2008-08-04 23:09   ` Dave
2008-08-04 23:28     ` Dan Williams
2008-08-06  0:37       ` Pavel Roskin
2008-08-06 18:33         ` Dave
2008-08-06 21:01           ` Dan Williams
2008-08-07  8:06             ` Jouni Malinen
2008-08-06 21:28         ` [PATCH 12/19] orinoco: Use extended Agere scans available on 9.x series firmwares kilroyd
2008-08-05 22:38     ` [Orinoco-devel] [PATCH 00/19] orinoco: WPA for Agere based cards Pavel Roskin
2008-08-08  0:02       ` Dave
2008-08-05 22:59     ` Pavel Roskin
2008-08-05 23:46       ` Dave
2008-08-06  0:41         ` [Orinoco-devel] " Pavel Roskin
2008-08-05 22:22   ` [PATCH 07/19] orinoco: Make firmware download logic more generic kilroyd
2008-08-05 22:22     ` [PATCH 09/19] orinoco: Invoke firmware download in main driver kilroyd
2008-08-05 22:22       ` [PATCH 12/19] orinoco: Use extended Agere scans available on 9.x series firmwares kilroyd
2008-08-20 19:28 ` [PATCH 00/19] orinoco: WPA for Agere based cards John W. Linville
2008-08-20 20:49   ` Dave
2008-08-20 21:06     ` Larry Finger
2008-08-20 21:07     ` Johannes Berg
2008-08-20 21:22       ` Johannes Berg
2008-08-20 23:07         ` Dave
2008-08-21  6:42           ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1217672073-7094-4-git-send-email-kilroyd@gmail.com \
    --to=kilroyd@googlemail.com \
    --cc=kilroyd@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=orinoco-devel@lists.sourceforge.net \
    --cc=proski@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).