Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Jasper Bryant-Greene <jasper@amiton.co.nz>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] replace net_device arguments with ieee80211_{local,sub_if_data} as appropriate
Date: Sun, 03 Aug 2008 11:31:15 +0200	[thread overview]
Message-ID: <1217755875.4721.14.camel@johannes.berg> (raw)
In-Reply-To: <1217721877.14226.12.camel@luna.unix.geek.nz> (sfid-20080803_020445_938315_49AA8B69)

[-- Attachment #1: Type: text/plain, Size: 1004 bytes --]

On Sun, 2008-08-03 at 12:04 +1200, Jasper Bryant-Greene wrote:
> This patch replaces net_device arguments to mac80211 internal functions
> with ieee80211_{local,sub_if_data} as appropriate.
> 
> It also does the same for many 802.11s mesh functions, and changes the
> mesh path table to be indexed on sub_if_data rather than net_device.
> 
> If the mesh part needs to be a separate patch let me know, but since
> mesh uses a lot of mac80211 functions which were being converted anyway,
> the changes go hand-in-hand somewhat.
> 
> This patch probably does not convert all the functions which could be
> converted, but it is a large chunk and followup patches will be
> provided.

Way cool. Unfortunately, your patch seems to be word-wrapped.

> -		mac80211_ev_michael_mic_failure(rx->dev, rx->key->conf.keyidx,
> +		mac80211_ev_michael_mic_failure(rx->sdata, rx->key->conf.keyidx,

I wonder if we can remove rx->dev at some point. Don't worry about it
right now though.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2008-08-03  9:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-03  0:04 [PATCH] replace net_device arguments with ieee80211_{local,sub_if_data} as appropriate Jasper Bryant-Greene
2008-08-03  9:31 ` Johannes Berg [this message]
2008-08-03 21:28   ` Jasper Bryant-Greene

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1217755875.4721.14.camel@johannes.berg \
    --to=johannes@sipsolutions.net \
    --cc=jasper@amiton.co.nz \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox