From: Johannes Berg <johannes@sipsolutions.net>
To: Luis Carlos Cobo <luisca@cozybit.com>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com
Subject: Re: [PATCH] mac80211: fix use of skb->cb for mesh forwarding
Date: Tue, 05 Aug 2008 21:00:09 +0200 [thread overview]
Message-ID: <1217962809.3603.56.camel@johannes.berg> (raw)
In-Reply-To: <48989ce7.2533440a.381b.ffff88f4@mx.google.com> (sfid-20080805_203321_417358_2008E391)
[-- Attachment #1: Type: text/plain, Size: 928 bytes --]
> static ieee80211_rx_result debug_noinline
> +ieee80211_rx_h_mesh_fwding(struct ieee80211_rx_data *rx)
> +{
> @@ -1683,6 +1697,8 @@ static void ieee80211_invoke_rx_handlers(struct ieee80211_sub_if_data *sdata,
> /* must be after MMIC verify so header is counted in MPDU mic */
> CALL_RXH(ieee80211_rx_h_remove_qos_control)
> CALL_RXH(ieee80211_rx_h_amsdu)
> + if (ieee80211_vif_is_mesh(&sdata->vif))
> + CALL_RXH(ieee80211_rx_h_mesh_fwding);
CALL_RXH cannot be used like that, it's not a statement, you should
probably make it one or put the vif_is_mesh test into the
ieee80211_rx_h_mesh_fwding function instead.
> +#define skb_get_80211_fc(skb) (((struct ieee80211_hdr *) skb->data) \
> + ->frame_control)
> + if (ieee80211_vif_is_mesh(&osdata->vif) &&
I'd rather just define the hdr struct you have two lines down before,
it'll just be optimised out when mesh isn't there.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2008-08-05 19:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-05 17:34 [PATCH] mac80211: fix use of skb->cb for mesh forwarding Luis Carlos Cobo
2008-08-05 19:00 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1217962809.3603.56.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=luisca@cozybit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox