Re: [PATCH] rt2x00: Add module parameter to disable HW crypto

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 935 bytes --]

On Wed, 2008-08-06 at 18:06 +0200, Ivo van Doorn wrote:
> On Wednesday 06 August 2008, Johannes Berg wrote:
> > On Wed, 2008-08-06 at 17:27 +0200, Ivo van Doorn wrote:
> > > Add a module parameter to rt61 and rt73 to disable
> > > HW crypto. The option should only be checked when
> > > determining if the SUPPORT_HW_CRYPTO flag should
> > > be set or not.
> > 
> > I wonder if instead mac80211 should have an option for this. It'd be
> > trivial to simply not tell the hardware about the keys.
> 
> Then it probably needs to be a per physical interface configuration option,
> which can only be toggled when the interface is down. Because I don't think
> you want the option to be global for all available physical interfaces.

Why not? It's mostly a debug option anyway. We can hide it away in
debugfs per phy, but I wouldn't really care if it was global since the
driver isn't supposed to be broken :)

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]