Re: [PATCH 1/1] iwlwifi: fix printk newlines

[Marcel Holtmann <marcel@holtmann.org>]

Hi Jiri,

> Add newlines at printk outputs to not break dmesg.
> 
> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
> Cc: Zhu Yi <yi.zhu@intel.com>
> Cc: Reinette Chatre <reinette.chatre@intel.com>
> Cc: John W. Linville <linville@tuxdriver.com>
> ---
>  drivers/net/wireless/iwlwifi/iwl-4965.c     |    2 +-
>  drivers/net/wireless/iwlwifi/iwl-eeprom.c   |    6 +++---
>  drivers/net/wireless/iwlwifi/iwl-sta.c      |    4 ++--
>  drivers/net/wireless/iwlwifi/iwl-tx.c       |    4 ++--
>  drivers/net/wireless/iwlwifi/iwl3945-base.c |    6 +++---
>  5 files changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/net/wireless/iwlwifi/iwl-4965.c b/drivers/net/wireless/iwlwifi/iwl-4965.c
> index 22bb269..4a0cc78 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-4965.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-4965.c
> @@ -967,7 +967,7 @@ static int iwl4965_interpolate_chan(struct iwl_priv *priv, u32 channel,
>  
>  	s = iwl4965_get_sub_band(priv, channel);
>  	if (s >= EEPROM_TX_POWER_BANDS) {
> -		IWL_ERROR("Tx Power can not find channel %d ", channel);
> +		IWL_ERROR("Tx Power can not find channel %d\n", channel);
>  		return -1;
>  	}

can we not just fix IWL_ERROR to always append the newline?

Regards

Marcel