From: Marcel Holtmann <marcel@holtmann.org>
To: Zhu Yi <yi.zhu@intel.com>
Cc: Jiri Slaby <jirislaby@gmail.com>,
ipw3945-devel@lists.sourceforge.net,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Reinette Chatre <reinette.chatre@intel.com>
Subject: Re: [ipw3945-devel] [PATCH 1/1] iwlwifi: fix printk newlines
Date: Tue, 12 Aug 2008 08:11:58 +0200 [thread overview]
Message-ID: <1218521518.25524.37.camel@californication> (raw)
In-Reply-To: <1218519496.3107.235.camel@debian.sh.intel.com>
Hi Yi,
> > > We should give the users more control to the style I think.
> >
> > what kind of control do you expect? If you need two lines of debug or
> > error output, call IWL_ERROR twice. This will also result in the
> > KERN_ERR is set and not forgotten since that has to follow the
> > newline.
>
> I thought sometimes we might not need a new line between two IWL_ERRORs.
> But your KERN_ERR garbaging the output in this case is correct. I think
> when we wrote the macro, we just follow the style of dev_info() ...
> dev_emerg() macros. Do you know why there is not a new line for them by
> default?
I have no idea. Maybe because they are close to printk. I always put the
newline into my macros.
Regards
Marcel
next prev parent reply other threads:[~2008-08-12 6:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-11 21:49 [PATCH 1/1] iwlwifi: fix printk newlines Jiri Slaby
2008-08-12 0:55 ` Marcel Holtmann
2008-08-12 1:22 ` [ipw3945-devel] " Zhu Yi
2008-08-12 3:59 ` Marcel Holtmann
2008-08-12 5:38 ` Zhu Yi
2008-08-12 6:11 ` Marcel Holtmann [this message]
2008-08-12 1:20 ` Zhu Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1218521518.25524.37.camel@californication \
--to=marcel@holtmann.org \
--cc=ipw3945-devel@lists.sourceforge.net \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).