From: Zhu Yi <yi.zhu@intel.com>
To: linville@tuxdriver.com
Cc: linux-wireless@vger.kernel.org,
Ron Rindjunsky <ron.rindjunsky@intel.com>,
Tomas Winkler <tomas.winkler@intel.com>,
Zhu Yi <yi.zhu@intel.com>
Subject: [PATCH 09/11] iwlwifi: fix station mimo power save values
Date: Thu, 28 Aug 2008 17:25:08 +0800 [thread overview]
Message-ID: <1219915510-3647-10-git-send-email-yi.zhu@intel.com> (raw)
In-Reply-To: <1219915510-3647-9-git-send-email-yi.zhu@intel.com>
From: Ron Rindjunsky <ron.rindjunsky@intel.com>
This patch fixes the wrong use of self mimo power save values instead of
peer's mimo power save values.
Signed-off-by: Ron Rindjunsky <ron.rindjunsky@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Signed-off-by: Zhu Yi <yi.zhu@intel.com>
---
drivers/net/wireless/iwlwifi/iwl-agn-rs.c | 3 ++-
drivers/net/wireless/iwlwifi/iwl-agn.c | 2 --
drivers/net/wireless/iwlwifi/iwl-dev.h | 1 -
3 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-rs.c b/drivers/net/wireless/iwlwifi/iwl-agn-rs.c
index 754fef5..90a2b6d 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn-rs.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn-rs.c
@@ -1153,7 +1153,8 @@ static int rs_switch_to_mimo2(struct iwl_priv *priv,
!sta->ht_info.ht_supported)
return -1;
- if (priv->current_ht_config.tx_mimo_ps_mode == IWL_MIMO_PS_STATIC)
+ if (((sta->ht_info.cap & IEEE80211_HT_CAP_MIMO_PS) >> 2)
+ == IWL_MIMO_PS_STATIC)
return -1;
/* Need both Tx chains/antennas to support MIMO */
diff --git a/drivers/net/wireless/iwlwifi/iwl-agn.c b/drivers/net/wireless/iwlwifi/iwl-agn.c
index b1cefb5..01db6d3 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn.c
@@ -586,8 +586,6 @@ static void iwl4965_ht_conf(struct iwl_priv *priv,
iwl_conf->supported_chan_width = 0;
}
- iwl_conf->tx_mimo_ps_mode =
- (u8)((ht_conf->cap & IEEE80211_HT_CAP_MIMO_PS) >> 2);
memcpy(iwl_conf->supp_mcs_set, ht_conf->supp_mcs_set, 16);
iwl_conf->control_channel = ht_bss_conf->primary_channel;
diff --git a/drivers/net/wireless/iwlwifi/iwl-dev.h b/drivers/net/wireless/iwlwifi/iwl-dev.h
index b00acf4..deec634 100644
--- a/drivers/net/wireless/iwlwifi/iwl-dev.h
+++ b/drivers/net/wireless/iwlwifi/iwl-dev.h
@@ -412,7 +412,6 @@ struct iwl_ht_info {
/* self configuration data */
u8 is_ht;
u8 supported_chan_width;
- u16 tx_mimo_ps_mode;
u8 is_green_field;
u8 sgf; /* HT_SHORT_GI_* short guard interval */
u8 max_amsdu_size;
--
1.5.3.6
next prev parent reply other threads:[~2008-08-28 9:29 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-28 9:24 [PATCH 00/11] iwlwifi driver fixes for 2.6.27 Zhu Yi
2008-08-28 9:25 ` [PATCH 01/11] iwlwifi: W/A for the TSF correction in IBSS Zhu Yi
2008-08-28 9:25 ` [PATCH 02/11] iwlwifi: use mac80211 band and channel settings Zhu Yi
2008-08-28 9:25 ` [PATCH 03/11] iwlwifi: fix hidden ssid discovery in passive channels Zhu Yi
2008-08-28 9:25 ` [PATCH 04/11] iwlwifi: remove false rxon if rx chain changes Zhu Yi
2008-08-28 9:25 ` [PATCH 05/11] iwlwifi: workaround interrupt handling no some platforms Zhu Yi
2008-08-28 9:25 ` [PATCH 06/11] iwlwifi: fix apm_stop Zhu Yi
2008-08-28 9:25 ` [PATCH 07/11] iwlwifi: generic init calibrations framework Zhu Yi
2008-08-28 9:25 ` [PATCH 08/11] iwlwifi: call apm stop on exit Zhu Yi
2008-08-28 9:25 ` Zhu Yi [this message]
2008-08-28 9:25 ` [PATCH 10/11] iwlwifi: fix rx_chain computation Zhu Yi
2008-08-28 9:25 ` [PATCH 11/11] iwlwifi: fix 64bit platform firmware loading Zhu Yi
2008-08-28 12:43 ` Marcel Holtmann
2008-08-28 12:41 ` [PATCH 10/11] iwlwifi: fix rx_chain computation Marcel Holtmann
2008-08-28 11:16 ` Tomas Winkler
2008-08-28 13:59 ` Marcel Holtmann
2008-08-28 14:37 ` Tomas Winkler
2008-08-28 12:40 ` [PATCH 09/11] iwlwifi: fix station mimo power save values Marcel Holtmann
2008-08-28 11:11 ` Tomas Winkler
2008-08-28 14:02 ` Marcel Holtmann
2008-08-28 14:38 ` Tomas Winkler
2008-08-28 12:39 ` [PATCH 08/11] iwlwifi: call apm stop on exit Marcel Holtmann
2008-08-28 10:52 ` Johannes Berg
2008-08-28 12:56 ` Marcel Holtmann
2008-08-28 10:58 ` Tomas Winkler
2008-08-28 14:09 ` Marcel Holtmann
2008-08-28 14:35 ` Tomas Winkler
2008-08-28 19:15 ` David Miller
2008-08-28 11:05 ` Johannes Berg
2008-08-29 1:58 ` Zhu Yi
2008-09-02 21:01 ` John W. Linville
2008-09-02 22:49 ` Tomas Winkler
2008-08-28 12:36 ` [PATCH 07/11] iwlwifi: generic init calibrations framework Marcel Holtmann
2008-08-28 11:20 ` Tomas Winkler
2008-08-28 14:12 ` Marcel Holtmann
2008-08-28 14:29 ` Tomas Winkler
2008-08-28 12:33 ` [PATCH 06/11] iwlwifi: fix apm_stop Marcel Holtmann
2008-08-28 11:21 ` Tomas Winkler
2008-08-28 12:23 ` Johannes Berg
2008-08-28 12:43 ` Tomas Winkler
2008-08-28 13:04 ` Michael Buesch
2008-08-28 14:34 ` Marcel Holtmann
2008-08-28 15:33 ` drago01
2008-08-28 11:38 ` Michael Buesch
2008-08-28 11:41 ` Tomas Winkler
2008-08-28 14:18 ` Marcel Holtmann
2008-08-28 12:32 ` [PATCH 05/11] iwlwifi: workaround interrupt handling no some platforms Marcel Holtmann
2008-08-28 12:30 ` [PATCH 04/11] iwlwifi: remove false rxon if rx chain changes Marcel Holtmann
2008-08-28 11:06 ` Tomas Winkler
2008-08-28 13:53 ` Marcel Holtmann
2008-08-28 12:29 ` [PATCH 03/11] iwlwifi: fix hidden ssid discovery in passive channels Marcel Holtmann
2008-08-28 10:40 ` Tomas Winkler
2008-08-28 12:49 ` Marcel Holtmann
2008-08-28 11:38 ` Tomas Winkler
2008-08-28 13:56 ` Marcel Holtmann
2008-08-28 12:27 ` [PATCH 02/11] iwlwifi: use mac80211 band and channel settings Marcel Holtmann
2008-08-28 11:32 ` Tomas Winkler
2008-08-28 13:57 ` Marcel Holtmann
2008-08-28 12:26 ` [PATCH 01/11] iwlwifi: W/A for the TSF correction in IBSS Marcel Holtmann
2008-09-02 21:05 ` [PATCH 00/11] iwlwifi driver fixes for 2.6.27 John W. Linville
2008-09-03 7:59 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1219915510-3647-10-git-send-email-yi.zhu@intel.com \
--to=yi.zhu@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=ron.rindjunsky@intel.com \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).