From: Marcel Holtmann <holtmann@linux.intel.com>
To: Tomas Winkler <tomasw@gmail.com>
Cc: Zhu Yi <yi.zhu@intel.com>,
linville@tuxdriver.com, linux-wireless@vger.kernel.org,
Mohamed Abbas <mohamed.abbas@intel.com>
Subject: Re: [PATCH 10/11] iwlwifi: fix rx_chain computation
Date: Thu, 28 Aug 2008 15:59:22 +0200 [thread overview]
Message-ID: <1219931962.6064.54.camel@californication> (raw)
In-Reply-To: <1ba2fa240808280416h7f8975d4v218e79b1c2aeedf1@mail.gmail.com>
Hi Tomas,
> >> This patch fixes and simplifies rx_chain computation.
> >
> > come on, what does it fix? You are submitting patches for -rc4 kernels.
>
> The fix is here
>
> + /* correct rx chain count accoridng hw settings */
while you are at it. Fix the spelling. It is "according" :)
> + if (priv->hw_params.rx_chains_num < active_rx_cnt)
> + active_rx_cnt = priv->hw_params.rx_chains_num;
> +
> + if (priv->hw_params.rx_chains_num < idle_rx_cnt)
> + idle_rx_cnt = priv->hw_params.rx_chains_num;
> +
>
> We would configure 1x2 MIMO like 3x3 -- big trouble
And that should be in the commit message. Even explain the trouble that
it causes.
Regards
Marcel
next prev parent reply other threads:[~2008-08-28 11:59 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-28 9:24 [PATCH 00/11] iwlwifi driver fixes for 2.6.27 Zhu Yi
2008-08-28 9:25 ` [PATCH 01/11] iwlwifi: W/A for the TSF correction in IBSS Zhu Yi
2008-08-28 9:25 ` [PATCH 02/11] iwlwifi: use mac80211 band and channel settings Zhu Yi
2008-08-28 9:25 ` [PATCH 03/11] iwlwifi: fix hidden ssid discovery in passive channels Zhu Yi
2008-08-28 9:25 ` [PATCH 04/11] iwlwifi: remove false rxon if rx chain changes Zhu Yi
2008-08-28 9:25 ` [PATCH 05/11] iwlwifi: workaround interrupt handling no some platforms Zhu Yi
2008-08-28 9:25 ` [PATCH 06/11] iwlwifi: fix apm_stop Zhu Yi
2008-08-28 9:25 ` [PATCH 07/11] iwlwifi: generic init calibrations framework Zhu Yi
2008-08-28 9:25 ` [PATCH 08/11] iwlwifi: call apm stop on exit Zhu Yi
2008-08-28 9:25 ` [PATCH 09/11] iwlwifi: fix station mimo power save values Zhu Yi
2008-08-28 9:25 ` [PATCH 10/11] iwlwifi: fix rx_chain computation Zhu Yi
2008-08-28 9:25 ` [PATCH 11/11] iwlwifi: fix 64bit platform firmware loading Zhu Yi
2008-08-28 12:43 ` Marcel Holtmann
2008-08-28 12:41 ` [PATCH 10/11] iwlwifi: fix rx_chain computation Marcel Holtmann
2008-08-28 11:16 ` Tomas Winkler
2008-08-28 13:59 ` Marcel Holtmann [this message]
2008-08-28 14:37 ` Tomas Winkler
2008-08-28 12:40 ` [PATCH 09/11] iwlwifi: fix station mimo power save values Marcel Holtmann
2008-08-28 11:11 ` Tomas Winkler
2008-08-28 14:02 ` Marcel Holtmann
2008-08-28 14:38 ` Tomas Winkler
2008-08-28 12:39 ` [PATCH 08/11] iwlwifi: call apm stop on exit Marcel Holtmann
2008-08-28 10:52 ` Johannes Berg
2008-08-28 12:56 ` Marcel Holtmann
2008-08-28 10:58 ` Tomas Winkler
2008-08-28 14:09 ` Marcel Holtmann
2008-08-28 14:35 ` Tomas Winkler
2008-08-28 19:15 ` David Miller
2008-08-28 11:05 ` Johannes Berg
2008-08-29 1:58 ` Zhu Yi
2008-09-02 21:01 ` John W. Linville
2008-09-02 22:49 ` Tomas Winkler
2008-08-28 12:36 ` [PATCH 07/11] iwlwifi: generic init calibrations framework Marcel Holtmann
2008-08-28 11:20 ` Tomas Winkler
2008-08-28 14:12 ` Marcel Holtmann
2008-08-28 14:29 ` Tomas Winkler
2008-08-28 12:33 ` [PATCH 06/11] iwlwifi: fix apm_stop Marcel Holtmann
2008-08-28 11:21 ` Tomas Winkler
2008-08-28 12:23 ` Johannes Berg
2008-08-28 12:43 ` Tomas Winkler
2008-08-28 13:04 ` Michael Buesch
2008-08-28 14:34 ` Marcel Holtmann
2008-08-28 15:33 ` drago01
2008-08-28 11:38 ` Michael Buesch
2008-08-28 11:41 ` Tomas Winkler
2008-08-28 14:18 ` Marcel Holtmann
2008-08-28 12:32 ` [PATCH 05/11] iwlwifi: workaround interrupt handling no some platforms Marcel Holtmann
2008-08-28 12:30 ` [PATCH 04/11] iwlwifi: remove false rxon if rx chain changes Marcel Holtmann
2008-08-28 11:06 ` Tomas Winkler
2008-08-28 13:53 ` Marcel Holtmann
2008-08-28 12:29 ` [PATCH 03/11] iwlwifi: fix hidden ssid discovery in passive channels Marcel Holtmann
2008-08-28 10:40 ` Tomas Winkler
2008-08-28 12:49 ` Marcel Holtmann
2008-08-28 11:38 ` Tomas Winkler
2008-08-28 13:56 ` Marcel Holtmann
2008-08-28 12:27 ` [PATCH 02/11] iwlwifi: use mac80211 band and channel settings Marcel Holtmann
2008-08-28 11:32 ` Tomas Winkler
2008-08-28 13:57 ` Marcel Holtmann
2008-08-28 12:26 ` [PATCH 01/11] iwlwifi: W/A for the TSF correction in IBSS Marcel Holtmann
2008-09-02 21:05 ` [PATCH 00/11] iwlwifi driver fixes for 2.6.27 John W. Linville
2008-09-03 7:59 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1219931962.6064.54.camel@californication \
--to=holtmann@linux.intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mohamed.abbas@intel.com \
--cc=tomasw@gmail.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).