From: Marcel Holtmann <holtmann@linux.intel.com>
To: David Miller <davem@davemloft.net>
Cc: yi.zhu@intel.com, linville@tuxdriver.com,
linux-wireless@vger.kernel.org, tomas.winkler@intel.com,
emmanuel.grumbach@intel.com
Subject: Re: [PATCH 4/9] iwlwifi: generic init calibrations framework
Date: Wed, 03 Sep 2008 10:10:11 +0200 [thread overview]
Message-ID: <1220429411.6714.17.camel@californication> (raw)
In-Reply-To: <20080902.203634.127434142.davem@davemloft.net>
Hi Tomas,
> > This patch fixes a critical bug that only the last calibration result
> > was applied. On reception of one calibration result all the calibration
> > results were freed therefore only last was applied. The patch fixes this
> > problem by introducing a generic init calibration framework which allows
> > variable number of init calibrations and allows addition new HW.
> >
> > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> > Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
> > Signed-off-by: Zhu Yi <yi.zhu@intel.com>
>
> This is borderline, I would rather hold off on such a sizable change
> for 2.6.27 as I'll have a hard time justifying it.
do you see any way for fixing (or improving) this with the current code
and hold the whole framework change off until the next merge window.
Maybe instead of iwl_free_calib_results(priv); just freeing them
individually in their case statements.
You know the hardware better than I do, but that should just work
(judging from the code).
Regards
Marcel
next prev parent reply other threads:[~2008-09-03 8:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-03 3:18 [PATCH 0/9 V3] iwlwifi driver fix for 2.6.27 Zhu Yi
2008-09-03 3:18 ` [PATCH 1/9] iwlwifi: W/A for the TSF correction in IBSS Zhu Yi
2008-09-03 3:18 ` [PATCH 2/9] iwlwifi: fix hidden ssid discovery in passive channels Zhu Yi
2008-09-03 3:18 ` [PATCH 3/9] iwlwifi: remove false rxon if rx chain changes Zhu Yi
2008-09-03 3:18 ` [PATCH 4/9] iwlwifi: generic init calibrations framework Zhu Yi
2008-09-03 3:18 ` [PATCH 5/9] iwlwifi: fix station mimo power save values Zhu Yi
2008-09-03 3:18 ` [PATCH 6/9] iwlwifi: fix rx_chain computation Zhu Yi
2008-09-03 3:18 ` [PATCH 7/9] iwlwifi: fix Tx cmd memory allocation failure handling Zhu Yi
2008-09-03 3:18 ` [PATCH 8/9] iwlwifi: call apm stop on exit Zhu Yi
2008-09-03 3:18 ` [PATCH 9/9] iwlwifi: fix STATUS_EXIT_PENDING is not set on pci_remove Zhu Yi
2008-09-03 3:39 ` David Miller
2008-09-03 3:38 ` [PATCH 8/9] iwlwifi: call apm stop on exit David Miller
2008-09-03 3:38 ` [PATCH 7/9] iwlwifi: fix Tx cmd memory allocation failure handling David Miller
2008-09-03 3:37 ` [PATCH 6/9] iwlwifi: fix rx_chain computation David Miller
2008-09-03 3:37 ` [PATCH 5/9] iwlwifi: fix station mimo power save values David Miller
2008-09-03 3:36 ` [PATCH 4/9] iwlwifi: generic init calibrations framework David Miller
2008-09-03 8:10 ` Marcel Holtmann [this message]
2008-09-03 9:23 ` Tomas Winkler
2008-09-03 13:59 ` Marcel Holtmann
2008-09-03 14:10 ` Tomas Winkler
2008-09-03 3:35 ` [PATCH 3/9] iwlwifi: remove false rxon if rx chain changes David Miller
2008-09-03 3:35 ` [PATCH 2/9] iwlwifi: fix hidden ssid discovery in passive channels David Miller
2008-09-03 3:34 ` [PATCH 1/9] iwlwifi: W/A for the TSF correction in IBSS David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1220429411.6714.17.camel@californication \
--to=holtmann@linux.intel.com \
--cc=davem@davemloft.net \
--cc=emmanuel.grumbach@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=tomas.winkler@intel.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox