linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Vasanthakumar Thiagarajan <vasanth@atheros.com>,
	linville@tuxdriver.com, linux-wireless@vger.kernel.org,
	Jouni Malinen <Jouni.Malinen@Atheros.com>,
	Luis Rodriguez <Luis.Rodriguez@Atheros.com>
Subject: Re: [PATCH] Ath9k: Add RF kill support.
Date: Sun, 07 Sep 2008 02:57:50 +0200	[thread overview]
Message-ID: <1220749070.6714.118.camel@californication> (raw)
In-Reply-To: <1220721572.10102.0.camel@johannes.berg>

Hi Johannes,

> > > CONFIG_ATH9K_RFKILL needs to be set
> > > to enable this support.
> > 
> > why do we have to introduce yet another config option for this? What is
> > the advantage of disabling RFKILL support? I really don't see it and all
> > these extra config options are rather confusing than useful.
> 
> "if EMBEDDED", I think you may want to build a router without rfkill
> stuff.

so what overhead is it to have RFKILL just enabled all the time. It is a
small subsystem and the extra code inside the drivers is also not that
much. So what are we really trying to save here?

I can see your router point, but does it really matter? I don't think so
and some routers allow to switch WiFi off and then they want the RFKILL
switch again. Also what about the LEDS subsystem. The same would apply
and we are not bothering in just enabling it.

Regards

Marcel



  parent reply	other threads:[~2008-09-07  0:57 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-06 12:38 [PATCH] Ath9k: Add RF kill support Vasanthakumar Thiagarajan
2008-09-06 17:15 ` Marcel Holtmann
2008-09-06 17:19   ` Johannes Berg
2008-09-06 17:23     ` Johannes Berg
2008-09-07  1:00       ` Marcel Holtmann
2008-09-07  7:17         ` Johannes Berg
2008-09-07 11:56           ` Henrique de Moraes Holschuh
2008-09-07 12:40             ` Johannes Berg
2008-09-07  0:57     ` Marcel Holtmann [this message]
2008-09-08  4:59   ` Vasanthakumar Thiagarajan
2008-09-08  5:22     ` Marcel Holtmann
2008-09-08  5:38       ` Vasanthakumar Thiagarajan
2008-09-08 15:10     ` Henrique de Moraes Holschuh
2008-09-09  7:53       ` vasanthakumar thiagarajan
2008-09-07 12:09 ` Henrique de Moraes Holschuh
2008-09-08  5:20   ` Vasanthakumar Thiagarajan
  -- strict thread matches above, loose matches on Subject: below --
2008-09-09  5:33 Mats Johannesson
2008-09-09 15:34 [PATCH] ath9k: " Vasanthakumar Thiagarajan
2008-09-09 15:42 ` Johannes Berg
2008-09-09 16:22   ` vasanthakumar thiagarajan
2008-09-09 15:46 ` Johannes Berg
2008-09-09 16:02   ` vasanthakumar thiagarajan
2008-09-09 16:15     ` Henrique de Moraes Holschuh
2008-09-09 16:15       ` vasanthakumar thiagarajan
2008-09-09 16:19 ` Henrique de Moraes Holschuh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1220749070.6714.118.camel@californication \
    --to=marcel@holtmann.org \
    --cc=Jouni.Malinen@Atheros.com \
    --cc=Luis.Rodriguez@Atheros.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=vasanth@atheros.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).