From: Dan Williams <dcbw@redhat.com>
To: Holger Schurig <hs4233@mail.mn-solutions.de>
Cc: linux-wireless@vger.kernel.org, Helmut Schaa <hschaa@suse.de>
Subject: Re: [RFC] mac80211: notify the user space about low signal quality
Date: Mon, 15 Sep 2008 11:19:12 -0400 [thread overview]
Message-ID: <1221491952.10177.65.camel@localhost.localdomain> (raw)
In-Reply-To: <200809151710.43827.hs4233@mail.mn-solutions.de>
On Mon, 2008-09-15 at 17:10 +0200, Holger Schurig wrote:
> > So why does this need a new event? Can't wpa_supplicant
> > monitor the signal quality (or level/noise if the driver
> > doesn't provide "quality") and do what it needs to do without
> > any changes to the kernel at all?
>
> It could, but to do this, wpa_supplicant (or whatever) would have
> to periodically get awake, send the query command to mac80211
> and get the result.
>
> With an event, it just sits sleeping until some interesting event
> arrives. Nicer programming idiom, AFAIK.
Except that everything that listens to WEXT events gets woken up every
time an event comes in anyway. So any card doing background scanning
will wake up the supplicant too; I honestly think that every few seconds
is OK here. BTW, make sure you rate-limit the background scanning
events from mac80211 in your patches to every few seconds (I picked 4
for ipw2200) otherwise it floods events and wakes up everything all the
time.
My main problem is that adding a beacon threshold to mac80211 isn't a
great idea because it's not a standard value and it's not something
really applicable to mac80211; it's policy which is different for
different programs, and the way you've implemented it here it's global
for the interface.
Dan
next prev parent reply other threads:[~2008-09-15 15:18 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-15 12:16 More thoughts about roaming Helmut Schaa
2008-09-15 12:29 ` [RFC] Implement basic background scanning Helmut Schaa
2008-09-15 14:32 ` Michael Buesch
2008-09-15 14:40 ` Helmut Schaa
2008-09-15 15:59 ` Johannes Berg
2008-09-15 16:35 ` Helmut Schaa
2008-09-16 8:43 ` Kalle Valo
2008-09-16 9:10 ` Johannes Berg
2008-09-16 9:20 ` Helmut Schaa
2008-09-16 11:06 ` Johannes Berg
2008-09-16 9:15 ` Tomas Winkler
2008-09-15 12:35 ` [RFC] mac80211: notify the user space about low signal quality Helmut Schaa
2008-09-15 14:07 ` Dan Williams
2008-09-15 14:34 ` Helmut Schaa
2008-09-15 15:28 ` Dan Williams
2008-09-15 16:45 ` Helmut Schaa
2008-09-16 1:21 ` Luis R. Rodriguez
2008-09-16 7:41 ` Helmut Schaa
2008-09-16 8:07 ` Kalle Valo
2008-09-16 8:12 ` Johannes Berg
2008-09-16 8:55 ` Kalle Valo
2008-09-23 18:21 ` John W. Linville
2008-09-16 8:00 ` Kalle Valo
2008-09-16 7:57 ` Kalle Valo
2008-09-15 15:10 ` Holger Schurig
2008-09-15 15:19 ` Dan Williams [this message]
2008-09-16 8:25 ` Kalle Valo
2008-09-16 8:50 ` Holger Schurig
2008-09-16 9:25 ` Helmut Schaa
2008-09-16 9:32 ` Helmut Schaa
2008-09-16 10:23 ` Holger Schurig
2008-09-15 15:17 ` Holger Schurig
2008-09-16 7:53 ` Kalle Valo
2008-09-15 12:41 ` [RFC] wpa_supplicant: trigger a scan if signal quality is low Helmut Schaa
2008-09-15 13:59 ` More thoughts about roaming Dan Williams
2008-09-15 14:18 ` Helmut Schaa
2008-09-15 14:45 ` Dan Williams
2008-09-16 7:09 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1221491952.10177.65.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=hs4233@mail.mn-solutions.de \
--cc=hschaa@suse.de \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).